zsh-users
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-users@zsh.org
Subject: Re: Setup git-stash completion for a function: $line is wrong
Date: Thu, 16 Mar 2017 23:54:04 +0000	[thread overview]
Message-ID: <20170316235404.GA23159@fujitsu.shahaf.local2> (raw)
In-Reply-To: <170316140224.ZM17994@torch.brasslantern.com>

Bart Schaefer wrote on Thu, Mar 16, 2017 at 14:02:24 -0700:
> On Mar 15, 12:59am, Daniel Hahler wrote:
> } Bart Schaefer:
> } > There's already (compdef cmd=service) e.g.
> } > 
> } >     compdef gsta=git
> } 
> } Yes, I am aware of that, and what I mean is more or less something in this
> } regard, e.g. by making it handle command+arguments.
> 
> For other readers of this thread:  Any input here on whether this is
> actually a common use case?

As a datapoint: in my zshrc, I have 12 wrapper functions of the «foo()
{ command foo "$@" }» form, and only one function that would benefit
from the proposed compdef enhancement.

That function takes 'git rev-list' arguments and runs 'tig' (a Git
history viewer, like gitk) on them:
.
    mytig() {
      if (( $# )); then
        tig --no-walk $(git log --pretty=%H "$@")
      else
        tig --date-order --all -150
      fi
    }

Writing a completion function for this helper today is a little tricky,
since 'autoload +X _git' doesn't define _git-log().  Under the proposal,
defining completion for this helper would simply be «compdef mytig='git
log --pretty=%H'».  (Or whatever syntax is decided on)

Cheers,

Daniel


  reply	other threads:[~2017-03-16 23:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12 16:37 Daniel Hahler
2017-03-12 22:27 ` Bart Schaefer
2017-03-14 23:59   ` Daniel Hahler
2017-03-16 21:02     ` Bart Schaefer
2017-03-16 23:54       ` Daniel Shahaf [this message]
2017-03-21  4:42         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170316235404.GA23159@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).