From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-users-return-23642-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 961578a7 for ; Mon, 17 Sep 2018 02:34:15 +0000 (UTC) Received: (qmail 23286 invoked by alias); 17 Sep 2018 02:34:00 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: List-Unsubscribe: X-Seq: 23642 Received: (qmail 9035 invoked by uid 1010); 17 Sep 2018 02:34:00 -0000 X-Qmail-Scanner-Diagnostics: from naara.laafc.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(49.212.139.33):SA:0(-1.9/5.0):. Processed in 2.218748 secs); 17 Sep 2018 02:34:00 -0000 X-Envelope-From: thb@laafc.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Date: Mon, 17 Sep 2018 11:27:15 +0900 From: Takeshi Banse To: zsh-users@zsh.org Subject: Re: change in zstyle file-patterns handling between 5.5.1 & 5.6(.2)? Message-ID: <20180917022715.GA17398@laafc.net> Mail-Followup-To: zsh-users@zsh.org References: <25E31A55-5918-42B8-83B4-DDC58A2D52EA@bitraven.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25E31A55-5918-42B8-83B4-DDC58A2D52EA@bitraven.io> User-Agent: Mutt/1.10.1+58 (eeffe44b) (2018-07-23) Hi, I've also found a near related problem in zstyle list-dirs-first; that is, zsh ignores list-dirs-first style. Step to reproduce: ~/.zshrc-minimal: ---- autoload -Uz compinit && compinit zstyle ':completion:*:*:*:*:*' group-name '' zstyle ':completion:*' list-dirs-first yes zstyle ':completion:*:descriptions' format '%B%F{black}%d%f%b' ---- Here is a shell session: ---- % zsh -f host% . ~/.zsh-minimal host% mkdir -p /tmp/test-dir/9dir{1,2} host% touch /tmp/test-dir/0file host% cat /tmp/test-dir/ files 0file 9dir1/ 9dir2/ ---- I would expect the following: ---- host% cat /tmp/test-dir/ directory 9dir1/ 9dir2/ files 0file ---- * ml.zsh-workers.454@bitraven.io [2018-09-16 20:50]: > Is this an intentional change? > How can I get the separation back in 5.6 (ideally in a way that also works > in 5.5)? If I revert the commit 6b4e78dce6a505d8dab5554d9925e38e13bb40ea like a workaround diff hunk at the end of this mail, it works here for these 2 particular issues. The diff at the end of this mail breaks the patch: "[PATCH] Completion: Small fixes for _files, _object_files" http://www.zsh.org/mla/workers/2018/msg00788.html So, my workaround diff is not good shape... I'm wondering if someone could help. Here is my trial diff: diff --git a/Completion/Unix/Type/_files b/Completion/Unix/Type/_files index 5df22ea46..2b0c5580a 100644 --- a/Completion/Unix/Type/_files +++ b/Completion/Unix/Type/_files @@ -121,7 +121,7 @@ for def in "$pats[@]"; do done fi else - _path_files -g "$pat" "$opts[@]" "$expl[@]" && ret=0 + _path_files "$expl[@]" -g "$pat" "$opts[@]" && ret=0 fi done (( ret )) || break