zsh-users
 help / color / mirror / code / Atom feed
From: lilydjwg <lilydjwg@gmail.com>
To: zsh-users@zsh.org
Subject: No fsync on history file? I lost my history
Date: Sun, 23 Sep 2018 16:52:46 +0800	[thread overview]
Message-ID: <20180923085246.GA19251@lilyforest.localdomain> (raw)

(Resending to zsh-users because my message to zsh-workers seemed to be
ignored.)

Hi there!

I just experienced a kernel oops. When I was back after a hard reset,
I lost my entire zsh history: the file was truncated to zero bytes.

I noticed zsh writes to a temporary file first, then renames, but
doesn't call fsync after finishing writing. I talked with my friend
knowing a lot about filesystems and I think a fsync will prevent this
kind of thing (or it'll be a kernel bug).

What do you think? Would you add the fsync call or make an option for
that? I recovered from a backup but it was not great experience.

-- 
Best regards,
lilydjwg

             reply	other threads:[~2018-09-23  8:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23  8:52 lilydjwg [this message]
2018-09-23 13:35 ` Daniel Shahaf
2018-09-23 14:22   ` lilydjwg
2018-09-23 14:46     ` Daniel Shahaf
2018-09-23 15:25       ` lilydjwg
2018-09-23 15:45         ` Daniel Shahaf
2018-09-23 19:40           ` Vincent Lefevre
2018-09-24  3:03             ` lilydjwg
2018-09-23 18:02         ` Mikael Magnusson
2018-09-24  3:04           ` lilydjwg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180923085246.GA19251@lilyforest.localdomain \
    --to=lilydjwg@gmail.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).