zsh-users
 help / color / mirror / code / Atom feed
From: lilydjwg <lilydjwg@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-users@zsh.org
Subject: Re: No fsync on history file? I lost my history
Date: Sun, 23 Sep 2018 22:22:55 +0800	[thread overview]
Message-ID: <20180923142255.GA4931@lilyforest.localdomain> (raw)
In-Reply-To: <1537709747.103981.1517680056.72C7A43E@webmail.messagingengine.com>

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

On Sun, Sep 23, 2018 at 01:35:47PM +0000, Daniel Shahaf wrote:
> lilydjwg wrote on Sun, 23 Sep 2018 16:52 +0800:
> > Would you add the fsync call or make an option for that?
> 
> I'd be happy to accept patches for this.

Here it is. I've checked that it works on my Linux system, but not sure
about other systems.

-- 
Best regards,
lilydjwg

[-- Attachment #2: 0001-Call-fsync-after-writing-out-new-histfile.patch --]
[-- Type: text/plain, Size: 746 bytes --]

From 78b1df1329b2c7bb2b6e78e5b7d70be4bbf103e2 Mon Sep 17 00:00:00 2001
From: lilydjwg <lilydjwg@gmail.com>
Date: Sun, 23 Sep 2018 22:12:56 +0800
Subject: [PATCH] Call fsync after writing out new histfile

to ensure the data is on disk before the rename in case of a system crash.
---
 Src/hist.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Src/hist.c b/Src/hist.c
index dbdc1e4e5..e128e9f14 100644
--- a/Src/hist.c
+++ b/Src/hist.c
@@ -2933,6 +2933,9 @@ savehistfile(char *fn, int err, int writeflags)
 		lasthist.text = ztrdup(start);
 	    }
 	}
+	fflush(out); /* need to flush before fsync */
+	if (fsync(fileno(out)) < 0 && ret >= 0)
+	    ret = -1;
 	if (fclose(out) < 0 && ret >= 0)
 	    ret = -1;
 	if (ret >= 0) {
-- 
2.19.0


  reply	other threads:[~2018-09-23 14:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23  8:52 lilydjwg
2018-09-23 13:35 ` Daniel Shahaf
2018-09-23 14:22   ` lilydjwg [this message]
2018-09-23 14:46     ` Daniel Shahaf
2018-09-23 15:25       ` lilydjwg
2018-09-23 15:45         ` Daniel Shahaf
2018-09-23 19:40           ` Vincent Lefevre
2018-09-24  3:03             ` lilydjwg
2018-09-23 18:02         ` Mikael Magnusson
2018-09-24  3:04           ` lilydjwg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180923142255.GA4931@lilyforest.localdomain \
    --to=lilydjwg@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).