From: lilydjwg <lilydjwg@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-users@zsh.org
Subject: Re: No fsync on history file? I lost my history
Date: Mon, 24 Sep 2018 11:03:20 +0800 [thread overview]
Message-ID: <20180924030320.GA25143@lilyforest.localdomain> (raw)
In-Reply-To: <20180923194018.GA18586@zira.vinc17.org>
On 2018-09-23 15:45:17 +0000, Daniel Shahaf wrote:
> Yes, I understand that fflush(3) must be called in order to flush data
> from libc's buffers into kernel buffers, which fsync(2) will later flush
> to disk. My question was whether the fflush() call being added was
> redundant because of the existing call on line 2927. It would be odd
> to have two fflush() calls in a row without fwrite() between them; and
> to have only one of them update lasthist.
Oh sorry I misread your message. The fflush() above isn't sufficient
because it's not called in my case. I don't know when the "if" will be
true but calling two fflush() is better than calling none.
Maybe calling only once above them is better, but this will leave the
fflush() a little far from where it's needed.
On Sun, Sep 23, 2018 at 09:40:19PM +0200, Vincent Lefevre wrote:
> But the first one is in a "if", thus might have not been called. Or
> there is an inconsistency in the conditions, which should be fixed.
What does HFILE_USE_OPTIONS mean? This seems to be unset when zsh exits.
--
Best regards,
lilydjwg
next prev parent reply other threads:[~2018-09-24 3:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 8:52 lilydjwg
2018-09-23 13:35 ` Daniel Shahaf
2018-09-23 14:22 ` lilydjwg
2018-09-23 14:46 ` Daniel Shahaf
2018-09-23 15:25 ` lilydjwg
2018-09-23 15:45 ` Daniel Shahaf
2018-09-23 19:40 ` Vincent Lefevre
2018-09-24 3:03 ` lilydjwg [this message]
2018-09-23 18:02 ` Mikael Magnusson
2018-09-24 3:04 ` lilydjwg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924030320.GA25143@lilyforest.localdomain \
--to=lilydjwg@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).