From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-users-return-24511-ml=inbox.vuxu.org@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id 38798674
	for <ml@inbox.vuxu.org>;
	Tue, 10 Dec 2019 05:56:06 +0000 (UTC)
Received: (qmail 5256 invoked by alias); 10 Dec 2019 05:56:00 -0000
Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Users List <zsh-users.zsh.org>
List-Post: <mailto:zsh-users@zsh.org>
List-Help: <mailto:zsh-users-help@zsh.org>
List-Unsubscribe: <mailto:zsh-users-unsubscribe@zsh.org>
X-Seq: 24511
Received: (qmail 22386 invoked by uid 1010); 10 Dec 2019 05:56:00 -0000
X-Qmail-Scanner-Diagnostics: from out5-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.1/25656. spamassassin: 3.4.2.  
 Clear:RC:0(66.111.4.29):SA:0(-2.6/5.0):. 
 Processed in 0.70947 secs); 10 Dec 2019 05:56:00 -0000
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
X-ME-Sender: <xms:TTPvXeMfBvNmozphlzsF2hNsR_W890kBmuTGLHAOk8Gjg_oSOe3RTQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelvddgkeehucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth
    ektddttderudenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn
    ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudektddrheejrdduudelne
    curfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhn
    rghmvgenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:TTPvXejCM2w_VHnc1wughtuU3pw9-faQuK_hXI8QOwTYRh9AvASLPg>
    <xmx:TTPvXUgDkbdR55lrHH8qvc2wFvNctKuLn9EkHNcWBB06rsfHJJwUEw>
    <xmx:TTPvXVLnDxNQt4C7AcMCgRYC8bxWawEzYMP_cIvpFesNzsm592i6aw>
    <xmx:TjPvXd6sYa8ukSLszEeODrg_hOmwWuGqHbDFAnlDww76Lvb-fMOLZg>
Date: Tue, 10 Dec 2019 05:55:23 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-users@zsh.org
Subject: Re: [WIP PATCH] vcs_info svn support for 'svnversion'
Message-ID: <20191210055523.qkbue75mnuaviipg@tarpaulin.shahaf.local2>
References: <20191201005217.m4rpqq623l4vapwe@tarpaulin.shahaf.local2>
 <20191210051734.xmo2pyn6m7vzblwr@tarpaulin.shahaf.local2>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191210051734.xmo2pyn6m7vzblwr@tarpaulin.shahaf.local2>
User-Agent: NeoMutt/20170113 (1.7.2)

Sorry for the double post but I found a minor bug just after sending.

Daniel Shahaf wrote on Tue, Dec 10, 2019 at 05:17:34 +0000:
>       if [[ ${output} == *:* ]]; then

Change «*:*» to «*[^0-9]*».

>   if [[ $non_uniform_revision == *:* ]]; then
>     integer min=${non_uniform_revision%%:*} max=${${non_uniform_revision#*:}%%[^0-9]*}
>     hook_com[revision]="r${min}:r${max}${non_uniform_revision//[0-9:]##}"
>     hook_com[revision]+=" (+$((max-min)))"

Add:

  else
    hook_com[revision]+="${non_uniform_revision//[0-9]##}"

>   fi
> 
>   return 0
> }

(The bug was that the 'S' and 'P' indication wouldn't show on uniform-revision
wc's, but only on mixed-revision ones.)

Cheers,

Daniel