From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>
Cc: Zsh Users <zsh-users@zsh.org>, ericdfreese@gmail.com
Subject: Re: emulate bash key bindings
Date: Fri, 10 Jan 2020 17:06:39 +0000 [thread overview]
Message-ID: <20200110170639.uvdidtgwswjqanhh@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAN=4vMogFDSK2+yKSg20639FYpKuONmsu_U4=rWV2arNQ4rQ1Q@mail.gmail.com>
[sorry for the late answer]
Roman Perepelitsa wrote on Thu, Jan 09, 2020 at 12:03:16 +0100:
> On Wed, Jan 8, 2020 at 11:25 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > That's true for z-sy-h's master branch, but with the feature/redrawhook
> > branch (due to be merged after 0.7.0's release) highlighting will be
> > refreshed even by invocations of dot-prefixed widgets.
>
> [cc:ericdfreese@gmail.com]
>
> That's useful to know. Thanks for the heads up.
>
> I took a look at the code and see that feature/redrawhook branch
> applies highlighting in zle-line-pre-redraw. Won't this cause issues
> when zsh-syntax-highlighting is used together with
> zsh-autosuggestions?
Yes, such issues were reported, last confirmed 4 days ago:
https://github.com/zsh-users/zsh-syntax-highlighting/issues/579
> zsh-autosuggestions doesn't wrap zle-line-pre-redraw by default, so it won't
> apply its own highlighting on top of zsh-syntax-highlighting.
Okay, and what could z-sy-h do about this? The redrawhook branch fixes a *lot*
of bugs, so I'm not eager to make it optional. I suppose I could just tell
people who use both plugins to stick to z-sy-h 0.7.0 (as opposed to master)
until there's a z-asug release that uses «add-zle-hook-widget
zle-line-pre-redraw» too — or is there a better solution that I'm overlooking?
> If zsh-autosuggestions starts wrapping zle-line-pre-redraw by default, there
> are still potential issues for users who upgrade their local
> zsh-syntax-highlighting before zsh-autosuggestions.
I'm not overly concerned about this. Anyone who uses z-sy-h from master should
_expect_ to live on the bleeding edge. Anyone who's not ready to live on the
bleeding edge should stick to tags (or, at least, follow master with an N days'
delay, so any issues will be ironed out before they get to it).
> There are also users who manually set ZSH_AUTOSUGGEST_IGNORE_WIDGETS.
And how does this affect z-sy-h?
Cheers,
Daniel
next prev parent reply other threads:[~2020-01-10 17:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200107184011eucas1p241073778b2cdd5bf7e94b43851273d49@eucas1p2.samsung.com>
2020-01-07 18:38 ` Andrey Butirsky
2020-01-08 2:26 ` Sebastian Gniazdowski
2020-01-08 2:37 ` Andrey Butirsky
2020-01-08 4:26 ` dana
2020-01-08 9:06 ` Mikael Magnusson
2020-01-08 10:00 ` Peter Stephenson
2020-01-08 21:55 ` Andrey Butirsky
2020-01-08 22:03 ` Roman Perepelitsa
2020-01-08 22:23 ` Daniel Shahaf
2020-01-09 0:05 ` Andrey Butirsky
2020-01-09 8:45 ` Roman Perepelitsa
2020-01-09 9:27 ` Andrey
2020-01-09 10:44 ` Roman Perepelitsa
2020-01-09 11:03 ` Roman Perepelitsa
2020-01-10 17:06 ` Daniel Shahaf [this message]
2020-01-10 17:35 ` Roman Perepelitsa
2020-01-10 18:09 ` z-sy-h and z-asug: zle-line-pre-redraw, POSTDISPLAY, coexistence (was: Re: emulate bash key bindings) Daniel Shahaf
2020-01-10 18:14 ` Roman Perepelitsa
2020-01-10 18:29 ` Daniel Shahaf
2020-01-10 18:43 ` Roman Perepelitsa
2020-01-10 19:14 ` Daniel Shahaf
2020-01-10 22:42 ` Sebastian Gniazdowski
2020-01-10 22:54 ` Roman Perepelitsa
2020-01-10 23:46 ` Sebastian Gniazdowski
2020-01-11 14:30 ` Roman Perepelitsa
2020-01-12 2:42 ` Sebastian Gniazdowski
2020-01-12 2:47 ` Sebastian Gniazdowski
2020-01-09 14:18 ` emulate bash key bindings Andrey Butirsky
2020-01-09 14:29 ` Peter Stephenson
2020-01-10 0:46 ` Andrey Butirsky
2020-01-10 9:51 ` Peter Stephenson
2020-01-10 10:58 ` Peter Stephenson
2020-01-10 11:07 ` Peter Stephenson
2020-01-10 11:47 ` Mikael Magnusson
2020-01-10 14:00 ` Andrey Butirsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110170639.uvdidtgwswjqanhh@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=ericdfreese@gmail.com \
--cc=roman.perepelitsa@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).