zsh-users
 help / color / mirror / Atom feed
From: Yasuhiro KIMURA <yasu@utahime.org>
To: zsh-users@zsh.org
Subject: Re: Avoid duplication of code
Date: Thu, 28 May 2020 19:24:22 +0900 (JST)
Message-ID: <20200528.192422.1842949111153083033.yasu@utahime.org> (raw)
In-Reply-To: <20200528085318.77063e24@tarpaulin.shahaf.local2>

From: Daniel Shahaf <d.s@daniel.shahaf.name>
Subject: Re: Avoid duplication of code
Date: Thu, 28 May 2020 08:53:18 +0000

>> ----------------------------------------------------------------------
>> update_tmux_ssh_agent_environments () {
>>     if [ -z "${TMUX}" ]
>>     then
>>         echo "This function must be called inside tmux session."
>>         return -1
>>     fi
> 
> You might want to add «local varname» here.
> 
>>     for varname in SSH_AGENT_PID SSH_AUTH_SOCK
>> }  
>> ----------------------------------------------------------------------
> 
> Cheers,

Thank you for pointing out. I added 'local newvalue varname' at the
top of function definition.

---
Yasuhiro KIMURA

      reply	other threads:[~2020-05-28 10:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25  9:02 Yasuhiro KIMURA
2020-05-25 14:22 ` Jun. T
2020-05-28  8:05   ` Yasuhiro KIMURA
2020-05-28  8:53     ` Daniel Shahaf
2020-05-28 10:24       ` Yasuhiro KIMURA [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200528.192422.1842949111153083033.yasu@utahime.org \
    --to=yasu@utahime.org \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

zsh-users

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/zsh-users

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-users zsh-users/ http://inbox.vuxu.org/zsh-users \
		zsh-users@zsh.org
	public-inbox-index zsh-users

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.users


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git