zsh-users
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Paul Ruane <paul.ruane@oniony.com>, zsh-users@zsh.org
Subject: Re: Cryptsetup completion
Date: Fri, 5 Jun 2020 01:55:51 +0000	[thread overview]
Message-ID: <20200605015551.341c5622@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <56544-1591271448.415496@8V8i.speh.Bt-A>

Oliver Kiddle wrote on Thu, 04 Jun 2020 13:50 +0200:
> Paul Ruane wrote:
> > The new patch--in correct format :)--is here:  
> 
> Thanks
> 
> > +++ b/Completion/Linux/Type/_crypto_ciphers  
> 
> These are just the cyphers handled by the Linux kernel, right? Is this
> naming perhaps too generic? _linux_ciphers perhaps?

+1

> We wouldn't want
> them to be used in other cases where something else such as openssl
> ciphers are wanted. Does anyone know for what other commands these might
> be relevant? If there are none, then I would contradict Daniel about
> factoring them out.

For the record, my rationale was simply that a function that completes
"'cipher' elements of /proc/crypto" seemed like it would be inherently
reusable.  Nevertheless, I'm not aware of a specific place where it
would be reused, and I wouldn't mind one way or the other whether it
should be factored out or not.

Separate issue: cryptsetup(8) says:
.
       --cipher, -c <cipher-spec>
	      … The current default in the distributed sources is
	      "aes-cbc-essiv:sha256" for plain dm-crypt and
	      "aes-xts-plain64" for LUKS. …
.
So it seems _linux_ciphers should not be used directly as _the_
completion function for arguments to the -c option.

Cheers,

Daniel

      reply	other threads:[~2020-06-05  1:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 16:17 Paul Ruane
2020-06-03  0:03 ` Mikael Magnusson
2020-06-03  0:55 ` Daniel Shahaf
2020-06-03 11:19   ` Paul Ruane
2020-06-03 12:52   ` Paul Ruane
2020-06-04  2:27     ` Daniel Shahaf
2020-06-04 11:50     ` Oliver Kiddle
2020-06-05  1:55       ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605015551.341c5622@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=okiddle@yahoo.co.uk \
    --cc=paul.ruane@oniony.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).