zsh-users
 help / color / mirror / Atom feed
* Bug report: region_highlight converts `fg=default` to `none`, which is not the same
       [not found] <CAHLkEDv9ch+nhtpYF3So+029J6GMv5iU-8=RzHRHLa7OYzc3kg@mail.gmail.com>
@ 2020-10-13 10:42 ` Marlon Richert
  2020-10-14 20:46   ` Daniel Shahaf
  0 siblings, 1 reply; 2+ messages in thread
From: Marlon Richert @ 2020-10-13 10:42 UTC (permalink / raw)
  To: zsh-users

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

Hi there, Zsh devs!

I am using Zsh 5.8 with `zsh-syntax-highlighting`. I want my paths to be
blue, but I want the slashes in each path to be my terminal's default text
color. I've configured `zsh-syntax-highlighting` to do so and it correctly
puts, for example,

```
region_highlight=( '0 2 fg=10' '3 16 fg=4' '3 4 fg=default' '9 10
fg=default' )
```

where `3 16` is the path I'm trying to `cd` to and  `3 4` plus `9 10` are
the positions of slashes in the path.

However, after this assignment occurs, when I `print -r
"${(q+)region_highlight[@]}"`, I get as output

```
'0 2 fg=10' '3 16 fg=4' '3 4 none' '9 10 none'
```

and when the ZLE highlights the line, the slashes are rendered in the same
blue color as the rest of the path. If I use any other `fg` value than `
default`, then the slashes are colored correctly.

This seems like incorrect behavior to me, on two accounts:

 1. It seems incorrect to convert `fg=default` to `none`. From reading the
[documentation](
http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting),
`none` is not supposed to be the same as `fg=default`.

 2. It also seems incorrect to me that `none` effectively does nothing at
all. According to the documentation, `none` should mean that

    > No highlighting is applied to the given context.

    Instead, `none` just appears to do nothing at all, which seems useless
to me; if I don't want to change the highlighting of that part of the line,
then I can just not add a spec for it.

Do you agree and could someone be so kind as to fix this? :)

Cheers,

Marlon

[-- Attachment #2: Type: text/html, Size: 2807 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug report: region_highlight converts `fg=default` to `none`, which is not the same
  2020-10-13 10:42 ` Bug report: region_highlight converts `fg=default` to `none`, which is not the same Marlon Richert
@ 2020-10-14 20:46   ` Daniel Shahaf
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Shahaf @ 2020-10-14 20:46 UTC (permalink / raw)
  To: zsh-users

Marlon Richert wrote on Tue, 13 Oct 2020 13:42 +0300:
> Hi there, Zsh devs!

The thread continues on -workers@, see workers/47445 et seq..

Cheers,

Daniel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-14 20:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAHLkEDv9ch+nhtpYF3So+029J6GMv5iU-8=RzHRHLa7OYzc3kg@mail.gmail.com>
2020-10-13 10:42 ` Bug report: region_highlight converts `fg=default` to `none`, which is not the same Marlon Richert
2020-10-14 20:46   ` Daniel Shahaf

zsh-users

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/zsh-users

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-users zsh-users/ http://inbox.vuxu.org/zsh-users \
		zsh-users@zsh.org
	public-inbox-index zsh-users

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.users


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git