From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30084 invoked from network); 23 Nov 2020 04:34:33 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 23 Nov 2020 04:34:33 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1606106073; b=Zgy5yCIpp0tSSyIJmtUFnQvRuXBgYTna+9LemN3KAkLSWDBZVJbYneE4enhyaaDKoibhibG94Z elUt+8js6jece/yp6NBfiinxfDn1cv7QXy7Qx71atAloHDP0XOmx+VC7NXDrcmcqdTGlwuNyHA 4NpwKkH95gVmbd+tKH95S+FU7Ib6OrCtvRw5JeLuizqkzEURfzldIDAF0HefAHK+zgza4RzSh+ FbxTU3xsIkVTB4raVhKG/L6XGbUqayKB/9nhQYNoqlfzwzAIjlJVAFoWV5VI1HwUpeXNi/RU5p CQs9vVRpyE7scd0WFJLVL+aHg+jJg81OAuf2zAGAn88jTA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out3-smtp.messagingengine.com) smtp.remote-ip=66.111.4.27; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1606106073; bh=uwqMSjBP+Vq5RDEV1STJXh2ZtMDhJkON7oDoZ1aQRKs=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=pGxmrMRitjoYmJb89YbR9YgzSJq3eprFp3Wr7zCDX72KlNOIJSHuCIm1oqavSb0RT4ZRA+RF2W qnEL2s5EEToqKXqXkW471IYfFzHrlvAILc9G8pDEwQzFobBeifW1mCME9YRccb647U6FYpLpL/ wt2HpcKPpX50PEGP0CItwO6TClskM3QuQ5+j2F+RsWBv25XF6X0a9/LTlgsSKX5che/qvYVgYu tacdWVPoq4AuHQx2lemgJwWEyPOeWEtkOdZQoAWkXxwDz1HwkOWv/+/3xtibbIV8tuzbC4fPCD laJFrC7grTcNXenRlGAhLgoDbP7s4rUOghWozgs6UsdvJA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=avcvlnzCcoKU9LKtuCofTeYiBnP4JyqKhZ3EEffqQxU=; b=VEipX0B4gOKFsxn3jvC8CpccX7 sSiKF186a7hrXwNzrtGXX5gD8z2WYtidbW4GGIBbE7YNdOxCZpnXXYJdMQPCfTo+RbB7PVJXaqoKi p0s78hFf8cdDolG5mrxyt0rxsesSw+86a8+McHuFLNFNUvO2/zCLxHRxjKzenM3CEAq0Z/0pD/wl/ x7zBspfSZ2inuP5gOiZXohQYhX/qYLehTt7rDPDK5g4pin6deW/U9/WXlgil4Reb5u09s6cRd/WjQ tTYdIBCzFYgtDH5a3Bu4LDJYqaGGxtcVHffy0BV0Y1k1kzQmpCgpqs557YPbd0CEhyGJiBD7dA8aJ hU7PIn+g==; Received: from authenticated user by zero.zsh.org with local id 1kh3Ya-000N4h-5y; Mon, 23 Nov 2020 04:34:28 +0000 Authentication-Results: zsh.org; iprev=pass (out3-smtp.messagingengine.com) smtp.remote-ip=66.111.4.27; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56585) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1kh3YA-000Mi7-I1; Mon, 23 Nov 2020 04:34:03 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D35665C0107; Sun, 22 Nov 2020 23:34:01 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 22 Nov 2020 23:34:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=fm1; bh=avc vlnzCcoKU9LKtuCofTeYiBnP4JyqKhZ3EEffqQxU=; b=Q+e7OYe4RTmzgY703wP NLhmfidNK97E7IKdeSofN/1OIsKzj2JqyIuvg5H9EgfertZIsEwNoIiLtALCCYYW HOxXX2rbUkNtgCrwY8GYzKQ0DPM43oSMpXaQuMj/PkvWKjybr2nJLAM/2j18gy8q LthySg59vemAdGu3pEZSz8nxr4jJG97RFWO1N2MVvCunrTx9jbY1TSFhpJJi+LB6 Oy7IF4JyTaOPmNEZyHIGk7bSZJHNMAMfBEFn33Usu53gk4CsAaLwT3YWSTH6zkZB tDfsf4JTSCTLdkgqqOkpbvJTw1rPvvC2c8FvNRQ6fBthqCiivXS9JcJtVe2ystnH Hyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=avcvln zCcoKU9LKtuCofTeYiBnP4JyqKhZ3EEffqQxU=; b=I+BErp9wRXC/DPwwYiq8UP CTWJdyN5TTieSBOiGEXs99ccdIsyb687hbCUJ1zNqoTadV1ADZ3Q6dZWKiahpyg6 PyUlaZC2E3awyJSGuwPduGsa/CLIME943GX+XMlXCTSVqbnVuTcbeOtE43FcA7So Di+PDU6k4guxGJ62OooW5kqACBpf2r726ShzUBvl7xnforF6kcMDWT8zBVtIvlHx qj22nTCM/TqVymfuCJA7CYuRzagB1Q3ehZxiVRckTshF9srA5nqBzBqezdikPcyA GYZk0BOXzBBPzExemjbncBf/Rn3LrhxTakQzlQWG9d2X+zzePJC9iRI3E/MPfZZQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeghedgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjfgesthdttddttdervdenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnhepueevkeefffeufeehfefhgefffedviedthedtgeeljeelvdei hfevjeefteegvdeknecukfhppeejledrudektddrieekrddufeehnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhs hhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-180-68-135.red.bezeqint.net [79.180.68.135]) by mail.messagingengine.com (Postfix) with ESMTPA id 535BF3064AA6; Sun, 22 Nov 2020 23:34:01 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4CfZ6b4Jd8z3kK; Mon, 23 Nov 2020 04:33:59 +0000 (UTC) Date: Mon, 23 Nov 2020 04:33:59 +0000 From: Daniel Shahaf To: Felipe Contreras Cc: zsh-users@zsh.org Subject: Re: git-completion 1.2 released Message-ID: <20201123043359.GC31253@tarpaulin.shahaf.local2> References: <20e670fa-074d-40c8-8bfd-b148fd0e3e77@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 26196 Archived-At: X-Loop: zsh-users@zsh.org Errors-To: zsh-users-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-users-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Felipe Contreras wrote on Sat, Nov 21, 2020 at 18:53:56 -0600: > On Sat, Nov 21, 2020 at 10:05 AM Daniel Shahaf wrote: > > > > Felipe Contreras wrote on Thu, 19 Nov 2020 16:05 +00:00: > > > Git-completion is a friendly fork of the official Git completion and > > > prompt scripts for Zsh and Bash. > > > > > > The main goal is to provide a more up-to-date completion for Zsh (I'm > > > the developer), which is basically just a wrapper around the Bash > > > completion. > > > > I was going to invite you to send patches to zsh's own _git, but then I > > noticed that in README.asciidoc you claim that you've sent patches to > > zsh's completion and "many" of them have been "ignored": > > Git's zsh completion, not Zsh's Git completion. Thanks for clarifying this. > > > Compared to Git upstream, you get many benefits for Zsh, for example: > > > no extra unnecessary spaces, correct auto suffix removal, colors > > > without PROMPT_COMMAND, custom aliases, fixed --no-options, and many > > > more. > > > > I suspect some of these have been fixed in zsh's _git since you last > > looked and others are configurable. (E.g., git-send-email(1), which you > > mention below, completes not only files but also recent commits, and has > > done so for a while.) > > But the main use of "git send-email" is not to receive random files, > it's to receive comittishes, and potentially some .patch files. > So, just this? Will anyone want to complete files that _don't_ have a .patch extension? diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git index 81a060e4d..8d1567e39 100644 --- a/Completion/Unix/Command/_git +++ b/Completion/Unix/Command/_git @@ -4443,7 +4443,7 @@ _git-send-email () { '--force[send emails even if safety checks would prevent it]' \ '(- *)--dump-aliases[dump configured aliases and exit]' \ '*: : _alternative -O expl - "files:file:_files" + "files:file:_files -g \"*.patch\"" "commits:recent commit object name:__git_commit_objects_prefer_recent"' } > If I do "git send-email master.." nothing completes with Zsh's > official completion. It does with mine. Thanks for the bug report.