From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 13080 invoked from network); 23 Nov 2020 15:45:44 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 23 Nov 2020 15:45:44 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1606146344; b=sY78HncMGEEkj75Ob98lPEYVH0nwKaVINlsoj57OrYBiDXajUUMNFakiEi4UjuFsQ8VUQ8fhl0 FhDaoNmlUT8THwOgeT+UlGYIqwUpfbZ5nd+af5xy9C6ONBJM0Q6Gdgr5ZOM29Tva2w6itYCtg9 TGr6jpAZjpuMp2fV/qVdwEK1DcxM4hMD9C6Uzv44lSX+MZSaKP9Cez5OcoHG+KL4FIpeGo7VG8 ZykkyHeMN0/axu/8fT5nJ2fofubF8Uf4gaUFIUDQA4mKmjf40MGKv84dqWBtB56ZN+3xY0M+rv VmSt2rbyvLQCQR32lr7fPOEx2cgasO/PQdIOLWS35sEpiw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1606146344; bh=+o0h51kwVaTirJx46WvUWE55yRW3W8oepjIbnduwI1I=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=ZsrelrWgfl2Zt+uMcUpuk4rq7DdrfVgZgacfeoEfkCa4fsK8552JjUyr/cNvDNhFjin+yWZR97 trtWbXDNZT/pVlsRb9gaJmbmxci/5/Cvrnax88QCNkXZSby2aIBa3okWjHKnHj8oz4yO8/prPl nSOS62XzX4XO2o9rcODTK9GB5SjvZzXWunjp5pxKJRzZOUpYLTx0l8mWm+KnVbZc1SKtU4lCr9 f5dYnCOuloM1q50QcDr+GfyGrikO5yPJ4wMC7mEUWhuJLkp5zVQPn++Hmp1+6OdYgGIPLscO/B 981HBVlzB1ymve0Ue9hO+scwkKjmE+4tatt+sMIbOjidPg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=9/5iBqlYJVS26mq9KOOXxWmkVAwB4+9vbb9nn61mCfw=; b=T8mZgC3150aIqw4CWOGnozRSKR qyZQIFZA1WKVsAO3EsVzMhHtvPSN+9BQ0S2/T/TSFNEF+kVFmJQ3qMflm/pZgaBskh+PFuCfaF6LO FXnAketfoLK7BRx05SA8A1chhN0P2jrEU5ruJBTk59fwqGZ27I5E6qFVAM44QyelmtDTpU41U+aqs iG/8UzZ6618uuVB1o2fjpOmhnKX7gPz+iMR61a1Q7fyrDAoTVkrMNVYLF4NZNY2DLP6i2bE6MV6AI A3VE5GEIqEh11CNn0uA4fZtZt6eb29T73yuuDY3n77VTL3eYWpIJsarsiH+6R80oQrcoYMxujPRkh PgWRZ+pA==; Received: from authenticated user by zero.zsh.org with local id 1khE29-000H7W-7t; Mon, 23 Nov 2020 15:45:41 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41949) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1khE1b-000GkI-Si; Mon, 23 Nov 2020 15:45:09 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A058A5C00E0; Mon, 23 Nov 2020 10:44:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 23 Nov 2020 10:44:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm1; bh=9/5iBqlYJVS26mq9KOOXxWmkVAwB4+9vbb9nn61m Cfw=; b=y5Spwrd5xEuFIgLvv5+x1C1VPBW6P7PN+HgioEnDVGypGdx7MZ/0LrtD bPmxDwkeGV1Qh7XHsJyW3B4/LpnN4ggG0Lk/vuhkm2MFWWxdp4vULzY4sWtWh+G4 voi9uehMseRM4vRGCa/+31esEKxtC5qcOu/D2C05gPS3bN46cEt3xrKkun6UUvKG 7VP4A6SxyFhrgfWZ3d0XHBFdcQoVIKyV8p0uOC6ICzVUGe4/XkiU8QlQm8Ns22In UTBzENYSoHFtNbZm3hbxat1I/f1j1iu+fGSK5p88Ss7F3U9CG4SeBFP/8ZqjUdTO pumKzvAKOVTxKd4kcynP0+fMGGoaeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=9/5iBqlYJVS26mq9KOOXxWmkVAwB4+9vbb9nn61mC fw=; b=nRi7lquzYV3HYMk/G8et52Umo5zgoW9j1eLh5pjFqu8DCNjJ1CC6TCgqC lwmb0fCGEoOlKx1ggow+b4yt57JHSbW7It6swKfBK57PwStIkeL5XzajtyRTUgci 2dSF9yq1D1iCn9ZfeFtRmuwpRJ0WpsLwmG+vaF98+rSt2W8a1U+PQbCoI9x++slG l7u1d1uBwfDVkKGh0qR55cn4idp1rL+vBa3gQVQlk1Y+wYWX+KbX68GOMHDtjSmf PutBC8Rnlt7gGflwpcTPPrI2rgb5EG8jRZGTLNWA8HfXyv0h6gPLPtQU1s96MzBv m6Zfx309GgBjFdiFLAYcwsll6Oyrg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegiedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjggfsehtkedttddtredunecuhfhrohhmpeffrghn ihgvlhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpefgleehtdffuefhgeeuleefffejgedttdelhedvvdeuiefh vefgvdfghfevvdekteenucfkphepjeelrddukedtrdeikedrudefheenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdr shhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-180-68-135.red.bezeqint.net [79.180.68.135]) by mail.messagingengine.com (Postfix) with ESMTPA id 0139C3280066; Mon, 23 Nov 2020 10:44:48 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4Cfs0Z4Ptjz3kK; Mon, 23 Nov 2020 15:44:46 +0000 (UTC) Date: Mon, 23 Nov 2020 15:44:46 +0000 From: Daniel Shahaf To: Felipe Contreras Cc: Zsh Users Subject: Re: git-completion 1.2 released Message-ID: <20201123154446.GA15080@tarpaulin.shahaf.local2> References: <20e670fa-074d-40c8-8bfd-b148fd0e3e77@www.fastmail.com> <20201123043359.GC31253@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 26198 Archived-At: X-Loop: zsh-users@zsh.org Errors-To: zsh-users-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-users-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Felipe Contreras wrote on Mon, Nov 23, 2020 at 01:49:16 -0600: > On Sun, Nov 22, 2020 at 10:34 PM Daniel Shahaf wrote: > > Felipe Contreras wrote on Sat, Nov 21, 2020 at 18:53:56 -0600: > > > > But the main use of "git send-email" is not to receive random files, > > > it's to receive comittishes, and potentially some .patch files. > > > > So, just this? Will anyone want to complete files that _don't_ have > > a .patch extension? > > Usually "git send-email" receives the patches generated by "git > format-patch", so yeah, *.patch should be enough. But it probably > wouldn't hurt to add *.diff files too, just in case. Let's do that for 5.9, then. Thanks. > > > If I do "git send-email master.." nothing completes with Zsh's > > > official completion. It does with mine. > > > > Thanks for the bug report. > > You're welcome. > > But that's just an example. Another example is that "git -C ~/dev/git > show " doesn't work, That looks straightforward to add, considering the --git-dir/--work-tree support already in place. > and the _git function has a TODO about -c since 2011. That TODO is so vague that it may well have been fixed at some point in the intervening decade. For instance, it so happens that I did a bunch of work on -c, but that work was in _git-config and I never saw that TODO comment until now. I suspect that TODO comment should simply be deleted for vagueness, especially given its age. > And there's a lot of others. > If so, they haven't been reported. We can't fix bugs unless they are reported to us. > I did some hacks to run Zsh's official Git completion against Git's > testing framework, and at least half of them fail. I could tell you > how to do that if you are interested. Thanks for the offer. We would be interested, if the results could be used without licensing concerns. zsh's _git is BSD-licensed. > So in my view it's clear the priorities of the two completions are > very different. It's nothing as deliberate as that. It's more likely just that nobody ever reported the bug whilst someone able and inclined to fix it happened to be listening. Also, in the specific case of «git -C», the Git maintainers probably use that option far more often than the average zsh user does (to run their HEAD builds against test repositories). Cheers, Daniel (Will read the other emails later; got to leave now.)