From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 12983 invoked from network); 1 Mar 2021 15:24:18 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 1 Mar 2021 15:24:18 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1614612258; b=mIYf2hdmlyl2q/0+tgbIhNsFFs94o4Ao0J61cUSdGIPNFzb9kofP3X90uPplJcr3D/tbGCIRCN koDZAuPZU8t0Jzt7i2mIYKi+7q6ir4kZWfn5M9BsDaydWRkfb2CHo3yZF460Bj7vMyI9TgAo0j El+ydoVH/eEL2jvDMo7jIj1RiYo72E0jxdSjqmTuiN2PwarkPXN/waBJAhAvugmTZTRWa5SMrX w9Z8CuEHobLjm55PHtU7z98z2b/NURwQnTzbqOl+Qcyaoe3DfXqQlYAsF21jCpxkxBbbB7fkmI 3FgwoG1IPCsaW/5oR/xw0SdkunRmS6LQl0vfl3KUUwer0A==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1614612258; bh=aowLYQHavfE0MD4QLRc3UreqY9P7H00uqLIVZCeI4Bg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=c3R5Yj2bIwdsIdktb22Ih2nKo/2zERXUDSwigcd3zZJ0oTDKD+V0yeEBsP2B3SLOYttaFJtDtW sjU2iHZT7sFU9IIWJjTz1xDrCyKpl2TdBj4QiAnPWly9bfnUaHzbzZX2UP8eL7MsSLnfBNASse wvF/zp9pp/frEUSL3Ubwkd5tWsK0ZQcj1I+hwBqy3rwkKJ20QDk2sRZXSWCSVfxS/wYuID7RJq xl25+T5HQFwhajSQwOiJoF88f0XywQ2ntjQhABjzHlzd4JYmnKHGDhswkcs2oSM492p2/Zg19P bmk1M1pHkhCPkoqUiPtfbzT0EdmB+rtcyzQKDIfaDSm3zQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=IZ6daYWCtbucCgunLhP/HZJJi+HnP6szd2k3HoTUwvo=; b=ugaBD6fs//pZd798z5LrM/R/X+ aYWs09reHLUJ+rONHImu+rz17UbPcxgrfE0ezX//VwsXKDt6dJwVM/pdx5WOjXB+P24GEtwO41EQH ggeiHxL1/0RkWgLVydXyzv+OhQcHzYFwqb2pBl9lZ/aIIZBJIT+8uVgochcBnncpa7fkpD/ayGDYH zgtVu1vuU36OB5qyo2dOy3rhuUOxNcMu3N5OZR0A1Giepin3jIU4F0QFqhuAy4hZ1uGhdsDJzhtDp Dgi+w8q6jV20vUF1hRlfFcxwQugHBZiz60WG0CYaD/au4qQriCTui9xVFVNu36BV4AUp3ADrQzexK Yx42YlVg==; Received: from authenticated user by zero.zsh.org with local id 1lGkPB-000OEI-7c; Mon, 01 Mar 2021 15:24:17 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43335) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lGkOj-000NrO-Dr; Mon, 01 Mar 2021 15:23:51 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id ACE045C005D; Mon, 1 Mar 2021 10:23:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 01 Mar 2021 10:23:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm2; bh=IZ6daYWCtbucCgunLhP/HZJJi+HnP6szd2k3HoTU wvo=; b=V4607uRJtn57OkNZjbIEJUTi6ggYsqSV9lP0a4nlHiLZl+bYxUrUeDwU AevZ3dTcXvkxI4pAb9R6+X/rfqLNNyJRjPD7T3EmJAhlaeKlQxHHRpmrU2EX0/7g 6XSGLG0gRQkcxsUVnMye8yYxm8u9jwQByWb83e8eSZqsW0v5sBX/AbAbxvQ6i6Ws 9zuMmaFBaBqrYGjZFgiX092Rp0cC8l6s3SiSemHAZy2iT2dX/8G0PnIB2kUhbazW EtpViDAWruD783eDAIvuw2sgfyWzRSxT7xqng8OSJv2Zu4VlKN2rSEwcBTWax7w5 s7nGC2OUlorPdoVizBXlwOG1dld5UA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=IZ6daYWCtbucCgunLhP/HZJJi+HnP6szd2k3HoTUw vo=; b=fgYrYk422LYJ4r0Rw6HODo4lR9s5tay4J9nXe4WRjV7RLsAoHY0ETWZop g4Q1Fv3u1cQl7bqlPtPHPfTeSf7+bnsOjAbpOD8alnUIYluJkfxpab9LQ77BP6tC mSH1eq9wc7Qp00vvinq+uUjOdKQoq+l6R5M7BePsjgw92N4sTf2TxEpdw+ztStrY YPFKHNmFeC5PU/S5jtOQOnaO1wWguHVlQm2dVKfRVBbNbDjC9s/bSwm5mSE6WT60 gAe5NOuBnSjRJG6IhCuxZuo8Sq5qTZBbfz43Bd35X2J4X+isISPFCCkepqiPPo1F EpyH8OXcVM4ahju6gUAzs4TbY8pXA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrleekgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjfgesthektddttderudenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnhepgfelhedtffeuhfegueelfeffjeegtddtleehvddvueeihfev gfdvgffhvedvkeetnecukfhppeejledrudejledrheelrdduvddtnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhs hhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-179-59-120.red.bezeqint.net [79.179.59.120]) by mail.messagingengine.com (Postfix) with ESMTPA id BB0A824005A; Mon, 1 Mar 2021 10:23:45 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4Dq3v42jNPzQ7; Mon, 1 Mar 2021 15:23:44 +0000 (UTC) Date: Mon, 1 Mar 2021 15:23:44 +0000 From: Daniel Shahaf To: Marc Chantreux Cc: Zsh Users Subject: Re: [PATCH] improve surfraw subcommands list Message-ID: <20210301152344.GA18578@tarpaulin.shahaf.local2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 26559 Archived-At: X-Loop: zsh-users@zsh.org Errors-To: zsh-users-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-users-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Marc Chantreux wrote on Sat, Feb 27, 2021 at 16:27:35 +0100: > diff --git a/Completion/Unix/Command/_surfraw b/Completion/Unix/Command/_surfraw > index f945f1ca9..343d275cc 100644 > --- a/Completion/Unix/Command/_surfraw > +++ b/Completion/Unix/Command/_surfraw > @@ -424,12 +424,26 @@ case $state in > yubnub) > _message -e command 'Yubnub Command' > ;; > + *) > + _message -e string 'search string' > + ;; > esac > ;; > elvi) > + local -UT XDG_CONFIG_DIRS xcd Don't play golf. Name it «xdg_config_dirs». > + # as it starts with a space, the header becomes an empty > + # string removed by the list expansion What? Does "the header" mean the first line of the output? > _wanted elvi expl elvi compadd \ > - ${${${(f)"$(_call_program elvi surfraw -elvi)"}%%[[:space:]]##--*}%:*} && ret=0 > + ${${(f)"$(surfraw -elvi)"}%%[[:space:]]*} $( Restore _call_program. > + # extract the keys of all bookmarks (should be in surfraw itself) > + awk '{keys[$1]=1} END {for (k in keys) print k}' \ Use a parameter expansion rather than an external dependency and a fork, if possible. If there's a reason to make an exception, it's not clear to me. > + $^xcd/surfraw/bookmarks(Nr) \ > + /etc/xdg/surfraw/bookmarks(Nr) \ > + /etc/surfraw.bookmarks(Nr) \ > + ${XDG_CONFIG_HOME-${HOME?homeless}/.config}/surfraw/bookmarks(Nr) \ > + ${HOME?homeless}/.surfraw.bookmarks(Nr) There shouldn't be an error message here at all, certainly not such a brief one. > Please use proper capitalization in your written English. > + ) && ret=0 > ;; > -esac > +esac > > return ret