zsh-users
 help / color / mirror / code / Atom feed
From: Tomasz Pala <gotar@polanet.pl>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-users@zsh.org
Subject: Re: cd /u/N/v/ tab expansion
Date: Sun, 10 Apr 2022 18:27:51 +0200	[thread overview]
Message-ID: <20220410162751.GA21675@polanet.pl> (raw)
In-Reply-To: <20220410143222.GA21848@polanet.pl>

On Sun, Apr 10, 2022 at 16:32:22 +0200, Tomasz Pala wrote:

> This happens with: setopt glob_complete interfering with
[...]
> $ mkdir -p usr/{share/{aclocal,atever},sbin,src}
> $ touch usr/sbin/a1 usr/share/a1 usr/share/a2
> 
> $ ls u/s*/a[tab]
[...]
> 
> My solution was to use:
> 
> zstyle ':completion:*:*:*:*' list-suffixes yes
> 
> but then:
> 
> $ mkdir -p  a/{b1,b2}/d/{e1,e2}/g
> $ ls a/b/d/e/g[tab]
> No matches for: `files' or `directory'

I've tracked down this problem down to the initial commit:
https://sourceforge.net/p/zsh/code/ci/e0dc80e0e54df85329b1644001df80e908fd5b9c/

around line 745 of _path_files (currently), there is this code:

	if [[ -z "$listsfx" ]]; then
		[...]
	else
		[[ -n "$compstate[pattern_match]" ]] && SUFFIX="${SUFFIX:s./.*/}*"

this SUFFIX manglignt is required for:

$ ls u/s*/a[tab]	changes "/a" to "*/a*"

but it breaks
$ ls a/b/d/e/g[tab]	changing "/d/e/g" to "*/d/e/g*"


In both cases all the files ARE compadded properly, the problem emerges
from the leading and trailing asterisks added to the SUFFIX.

1. why the "*/d/e/g*" SUFFIX prevents completions from being used?
2. should it be left intact? What makes this *required* for u/s*/a?
3. if to be left intact - how to prevent this from happening? The only
difference I see are MATCH=/ MBEGIN=6 MEND=6.


The solution I've came works for me, but I got no idea why and if that's
even the rational way:

-	[[ -n "$compstate[pattern_match]" ]]			&& SUFFIX="${SUFFIX:s./.*/}*"
+	[[ -n "$compstate[pattern_match]" ]] && [ -z "$MATCH" ] && SUFFIX="${SUFFIX:s./.*/}*"



This code is full of hackery... "pws non-canonical hack", "A little
extra hack", "it should now be smart"...


-- 
Tomasz Pala <gotar@pld-linux.org>


  reply	other threads:[~2022-04-10 16:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 12:40 zzapper
2022-04-07 20:11 ` Bart Schaefer
2022-04-07 20:20   ` zzapper
2022-04-07 23:11     ` Bart Schaefer
2022-04-08  9:53       ` zzapper
2022-04-08 17:57         ` Bart Schaefer
2022-04-08 10:22       ` david rayner
2022-04-08 18:09         ` Bart Schaefer
2022-04-10  1:04       ` Tomasz Pala
2022-04-10 14:32         ` Tomasz Pala
2022-04-10 16:27           ` Tomasz Pala [this message]
2022-04-10 16:32             ` Tomasz Pala
2022-04-10 17:45               ` Tomasz Pala
2022-04-10 18:05                 ` Tomasz Pala
2022-04-16 14:17                   ` Tomasz Pala
2022-04-17  3:00           ` Bart Schaefer
2022-04-17 16:17             ` Tomasz Pala
2022-04-17 18:15               ` Bart Schaefer
2022-04-17 18:44                 ` Bart Schaefer
2022-04-17 18:32               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220410162751.GA21675@polanet.pl \
    --to=gotar@polanet.pl \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-users@zsh.org \
    --subject='Re: cd /u/N/v/ tab expansion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).