zsh-users
 help / color / mirror / code / Atom feed
From: Vincent Lefevre <vincent@vinc17.net>
To: zsh-users@zsh.org
Subject: Re: prevent some lines directly coming from the history from being executed
Date: Wed, 25 May 2022 10:49:20 +0200	[thread overview]
Message-ID: <20220525084920.GB97860@zira.vinc17.org> (raw)
In-Reply-To: <CAH+w=7apO+iFprYnGwTbrrV-jS7WEv1m7uok7NgXpoXGqS_F8w@mail.gmail.com>

On 2022-05-24 20:59:53 -0700, Bart Schaefer wrote:
> zle-line-finish() {
>   if [[ $BUFFER = ${history[$HISTNO]} ]]; then
>     local confirm
>     read -q confirm"?Confirm: $BUFFER ?"
>     [[ $confirm = y ]] || BUFFER=""
>   fi
> }

There are some display issues in some cases due to the "Confirm"...
Instead, if the condition is met, is it possible to remain in ZLE
with the current buffer, as if I didn't do accept-line?
(I could set a psvar element so that I could change the prompt to
indicate that this needs confirmation.)

Or perhaps I could change the bindings to use a wrapper around
accept-line (ditto for accept-line-and-down-history).

Something like that (to be completed with pattern matching):

zle -A accept-line real-accept-line

accept-line-wrapper() {
  if [[ -z $psvar[3] && $BUFFER = ${history[$HISTNO]} ]]; then
    psvar[3]="[Confirm]"
    zle reset-prompt
  else
    psvar[3]=""
    zle real-accept-line
  fi
}

zle -N accept-line accept-line-wrapper

where $PS1 contains "%3v", and with psvar[3]="" in precmd().

Could there be any issue? Or is there anything to add?

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)


  reply	other threads:[~2022-05-25  8:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 15:47 Vincent Lefevre
2022-05-24 18:58 ` Bart Schaefer
2022-05-25  2:54   ` Vincent Lefevre
2022-05-25  3:59     ` Bart Schaefer
2022-05-25  8:49       ` Vincent Lefevre [this message]
2022-05-26  1:25         ` Bart Schaefer
2022-05-26 14:36           ` Vincent Lefevre
2022-05-26 15:53             ` Daniel Shahaf
2022-05-26 16:13               ` Peter Stephenson
2022-05-27 12:40                 ` Daniel Shahaf
2022-05-28  0:07                   ` Vincent Lefevre
2022-05-28 10:06                     ` Daniel Shahaf
2022-05-28 18:43                       ` Bart Schaefer
2022-05-29 22:55                         ` Daniel Shahaf
2022-05-30  4:04                           ` Bart Schaefer
2022-05-30  9:07                             ` Peter Stephenson
2022-06-02  9:59                               ` Daniel Shahaf
2022-06-02 10:19                               ` Daniel Shahaf
2022-06-02  9:59                             ` Daniel Shahaf
2022-05-30  9:02                       ` Vincent Lefevre
2022-06-02 10:17                         ` Daniel Shahaf
2022-06-02 13:54                           ` Vincent Lefevre
2022-05-26 16:37             ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220525084920.GB97860@zira.vinc17.org \
    --to=vincent@vinc17.net \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).