From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 6771 invoked from network); 21 Nov 2020 16:06:09 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 21 Nov 2020 16:06:09 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1605974769; b=GQaIIGZDbZuufCq26nqqkVsgEivwKDmYqTDb3gL/aecU8TgZef/OxvJPvh9DV1uXomCDLBFHnU Vz9uBT9OwyGOjZXf/Hnn+NMlTYQ2Gu6NS2LniQk0SYDQjxya88UTxNdHjlqh8VD1ugnHEel1ek RK52e01WF/jexc4rNDeH3JPkbHjwBZh5nyZ10CeuoPfY8rqcGf7Zm3v1HZlGN5YVPaSNW2qgwG LneEr8TCiSh2MnNcxNTOHB+I7rZdSRmXgaYcA8OqKsqeeVV2FDHJUPBfIvQ2wkcrjIPyl/ksqO RGJJz+LIiKwmkgv4psNoWId46ESDcrL45buVCeGOK8z6gQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout1-smtp.messagingengine.com) smtp.remote-ip=64.147.123.24; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1605974769; bh=p3GMiWhJAgtZsw5u1wZj3W1Akkt2uApG24J0CPS8tko=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Subject:To:From:Date: References:In-Reply-To:Message-ID:MIME-Version:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=HolMHkxgWJGh6GK64dJnfDzYvLYv33J4fFUswyeV58VFVAuyFbrdC1DaEtcXfxUJOEQErfPp2J JAW4M2mWlrdmVCfCbJA1l5s5+FhL9CCGISgs1YwvKt2ypaYlOLEuBPbUFN0DXPBAbO1CsEAjff GpazphQMXQjV6Ji2OPa7aOpIPK/N9n+tIxmok3xCkoExwS4RO1Y4nXcw3jlqPazlo2AnIR2qF8 r2PU1rjBWgVoHMuNNwNWsKM2Rrr+3bqG9aHDLymC3t0gG+TnO1BpopspE/AI5ToXoaNagSD/AG VLx3Tn/gfzfuoEUEgtspjGyAzY6FKVi3zElhmX1WtKZUHg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Subject:To:From:Date:References:In-Reply-To:Message-Id: Mime-Version:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=lEhNK3MT6i7wlbF+kpfSSHQtb/njFCxEmos4EmQfaz8=; b=QQcDHtONKFY6cwWE+qVCsr+r2r gyAb5qxls27CojE7ruhmqY8xl2QBaqPs4yzKH2YGb638fOihBBZC+GgtJ4Hwt1l50Zodg+Hgdd6Cs 16VA7L4tgTgHYZLbLhAgmdKNqsjT7NTRGCXf1JpNesc5QQbmiFqMW831ayLOnXb4RKTD/SBj0FAIW kiGCp/Q9PPhRU4Drn4vQtETKweBMdqXNsoBncXLph6BcbSyURZE5ztStMMPY9gUmmpfXSQE3F13yI 3pMqZ2JL6p7krXvz8CBdv2NQvOPUiUTW8F5WH+yPK5/VGcGs5/Pd6KUUUR5jjZpaCC7LsUOog9LPk YIM+GMxg==; Received: from authenticated user by zero.zsh.org with local id 1kgVOo-000EG5-I8; Sat, 21 Nov 2020 16:06:06 +0000 Authentication-Results: zsh.org; iprev=pass (wout1-smtp.messagingengine.com) smtp.remote-ip=64.147.123.24; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:32807) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1kgVOH-000Dsn-2I; Sat, 21 Nov 2020 16:05:34 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7E75CD15; Sat, 21 Nov 2020 11:05:31 -0500 (EST) Received: from imap37 ([10.202.2.87]) by compute3.internal (MEProxy); Sat, 21 Nov 2020 11:05:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=mime-version:message-id:in-reply-to :references:date:from:to:subject:content-type :content-transfer-encoding; s=fm1; bh=lEhNK3MT6i7wlbF+kpfSSHQtb/ njFCxEmos4EmQfaz8=; b=rJ7jy0WClhMFNAewkvBdEZax8R7K5ncvf5DFpV4WZD GawqbHF6bvyMEbXE7SKnkeL7rCRJR646Nx2AaVuuRIByRcYH7TILQMyY6I7bqskG sYpUr2V2ugePL7kLeqkNfS3+3xAODFAWtjdxS8XrWL7o1gP4SCOEEBKjt5Uqu604 gORmH6Tnd5t3+laTZc2XusDBqkdl9StIEof/V4Af6V+h6nA3pLzNqFK2y7xxJIYv fHz/dYiiPDMRIh4bWLbRJhzvBTMzzkytnhfrx/nRKnYqiXuWodq84KCTFTWr3doU STy3gGboFuHT39vGDET4sWb+N39HK+gm8948V+D0v1bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=lEhNK3MT6i7wlbF+kpfSSHQtb/njFCxEmos4EmQfa z8=; b=fqEkXVtemHnd9I9ZTe514YKWYQm/8DCCAAanFWtCdGevHHagWfqEXeLwb N9ZDsyZTeBR4iScD9rcJfNxuGngJdc4n6hdLvmQUG/35djL7ib4iEEL+sTP9JCML LVRbHPAB4ua4z9joItH7hKzAtkat4W7OGlMm3relVvqv2oWtAtRK8RHMSr9QK7HO k2iOPndjLuxOa0XOSwyIh/dW+JcrCkV6fRPNYzLEmeTTyJfFeqXLRiHQ7jLjA368 bP2AxJoNMC8mFgElps5oxS+iyvoFRbTFD1jODlIKizkq4fijYpizNSeGqztyCCH/ 59f1mRdi8HDDirXGhLQuJkMwRebnw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegvddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedfffgr nhhivghlucfuhhgrhhgrfhdfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmh gvqeenucggtffrrghtthgvrhhnpeeghedtueejueeulefftdeitdefieetueekkeehledu uedvtdetledvtdefueefteenucffohhmrghinhepfhhprghthhdrlhhotggrlhdpghhith hhuhgsrdgtohhmpdhtrhgrvhhishdqtghirdhorhhgnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfh drnhgrmhgv X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id CE310190006D; Sat, 21 Nov 2020 11:05:29 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-622-g4a97c0b-fm-20201115.001-g4a97c0b3 Mime-Version: 1.0 Message-Id: <20e670fa-074d-40c8-8bfd-b148fd0e3e77@www.fastmail.com> In-Reply-To: References: Date: Sat, 21 Nov 2020 16:03:48 +0000 From: "Daniel Shahaf" To: "Felipe Contreras" , zsh-users@zsh.org Subject: Re: git-completion 1.2 released Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Seq: 26190 Archived-At: X-Loop: zsh-users@zsh.org Errors-To: zsh-users-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-users-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Felipe Contreras wrote on Thu, 19 Nov 2020 16:05 +00:00: > Git-completion is a friendly fork of the official Git completion and > prompt scripts for Zsh and Bash. >=20 > The main goal is to provide a more up-to-date completion for Zsh (I'm > the developer), which is basically just a wrapper around the Bash > completion. I was going to invite you to send patches to zsh's own _git, but then I noticed that in README.asciidoc you claim that you've sent patches to zsh's completion and "many" of them have been "ignored": > > Most Git developers use the Bash shell, for which the completion scr= ipts work > > rather well, however, Zsh is typically neglected. I've sent many pat= ches to fix > > the issues, many have been merged, but many have been ignored, thus = the need for > > a canonical location of a good, working Zsh completion. I went back through the archives (and by this I mean the _complete_ archives, all the way back to 1995) and looked for git-related patches and threads from you (using =C2=AB~(~f Contreras ~s 'git|patch')=C2=BB i= n Mutt, if anyone wonders). Here's what I found: In April 2011 you sent 29208, which was accepted; 29041, which was accepted; and 29055, which began a long thread that doesn't contain any unified diffs. I didn't read the thread in full since, according to the= subsequent thread starting in 29158, the 29055 thread ended up in a disagreement not unlike the one you and Roman had just this week. I also saw your 31343 and 31415, but they don't contain patches. Which is to say, I have not found a _single_ patch from you that has been "ignored", and for that matter, I haven't found a single patch from= you that has "not been merged", either; and the last _git-related disagreement between you and the zsh developers is almost a decade ago. Which is to say, I have failed to convince myself that the statement in = your README.asciidoc is accurate. The invitation stands. > Compared to Git upstream, you get many benefits for Zsh, for example: > no extra unnecessary spaces, correct auto suffix removal, colors > without PROMPT_COMMAND, custom aliases, fixed --no-options, and many > more. I suspect some of these have been fixed in zsh's _git since you last looked and others are configurable. (E.g., git-send-email(1), which you= mention below, completes not only files but also recent commits, and has= done so for a while.) I also suspect that zsh's _git has features that yours lacks. > If you use the official Zsh completion the main benefit is that it's > blazingly fast. Simply doing "git log " on the Linux kernel (with= > 3k+ refs) takes several seconds on the official Zsh completion (about > 3 seconds on my machine), with git-complete it's *instantaneous*. >=20 Are you comparing apples to apples or to oranges? I.e., does it take more time to produce the _same set_ of result, or to produce a different set? > There's other benefits too. Since the Bash completion is actively > maintained by Git developers, everything works as they intend too. >=20 > For example "git send-email " correctly completes branches, as > opposed to files in the Zsh official completion. Also, complex aliases= > such as '!f () { }; f' are correctly identified and completed > out-of-the-box. >=20 > It's a sister project of the Oh My Zsh gitfast plugin [1], which I mai= ntain too. >=20 > Since the last version a testing framework was added, and now all the > completion tests of the Git project pass with the Zsh wrapper too [2].= >=20 > For installation instructions, and more information, check the wiki > [3], but basically. >=20 > * make install > * fpath=3D(~/.local/share/git-completion/zsh $fpath) >=20 > Enjoy. >=20 > [1] https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/gitfast > [2] https://travis-ci.org/github/felipec/git-completion > [3] https://github.com/felipec/git-completion/wiki/Zsh >=20 > --=20 > Felipe Contreras >=20 >