zsh-users
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Philip <weirdofreak@gmail.com>
Cc: zsh-users@sunsite.dk
Subject: Re: imagemagick completes for all files
Date: Wed, 27 Sep 2006 11:55:33 +0200	[thread overview]
Message-ID: <26118.1159350933@dcle12> (raw)
In-Reply-To: <20060923210240.GA13304@phil.en.oaci.org>

On 23 Sep, Philip wrote:
> My imagemagick completion lists all files, not just images.

Looks like it has been broken for a long time.

> I'm not sure what the (-.) means, but removing that doesn't help either,

It limits the glob to filenames so you would need to have a directory
with a .jpeg extension or something before you'd notice a difference.

You correctly identified the lines causing the problems. The patch below
fixes it for me. Hopefully this applies cleanly against the latest CVS.
I've using whatever comes with Solaris 10 here.

Oliver

--- /usr/sfw/share/zsh/4.2.1/functions/Completion/Unix/_imagemagick	Sat Jan  8 11:43:08 2005
+++ /home/okiddle/.zfunc/_imagemagick	Wed Sep 27 11:49:09 2006
@@ -14,7 +14,7 @@
 formats=jpg:jpeg:tiff:miff:ras:bmp:cgm:dcx:ps:eps:fig:fits:fpx:gif:mpeg:pbm:pgm:ppm:pcd:pcl:pdf:pcx:png:rad:rgb:rgba:rle:sgi:html:shtml:tga:ttf:uil:xwd:xbm:xpm:yuv
 
 if (( $# )); then
-  _files "$@" "$expl[@]" -g '*.(#i)(${~format//:/|})(-.)'
+  _files -g "*.(#i)(${~formats//:/|})(-.)" "$@"
   return
 fi
 


  reply	other threads:[~2006-09-27  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-23 21:02 Philip
2006-09-27  9:55 ` Oliver Kiddle [this message]
2006-09-27 13:19   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26118.1159350933@dcle12 \
    --to=okiddle@yahoo.co.uk \
    --cc=weirdofreak@gmail.com \
    --cc=zsh-users@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).