_expand_word_and_keep of 'keeper suite' doesn't work

_expand_word_and_keep of 'keeper suite' doesn't work

[Hannu Koivisto]

Greetings,

The version of _expand_word_and_keep below (from the magazine
article) doesn't seem to work in at least 4.2.5.  For some reason
the condition [[ $args[-J] == all-expansions ]] is never true when
and nothing is put to the kept variable.  I have no idea of what that
condition is there for, but just for the heck of it I tried
removing it completely.  Then, ... *.jpg<C-x e> caused *.jpg to be
put to the kept variable.

Any ideas?

_expand_word_and_keep() {
    function compadd() {
        local -A args
        zparseopts -E -A args J:
        if [[ $args[-J] == all-expansions ]]; then
            builtin compadd -A kept "$@"
            kept=( ${(Q)${(z)kept}} )
        fi
        builtin compadd "$@"
    }
    local result
    _main_complete _expand
    result=$?
    unfunction compadd
    return result
}

zle -C _expand_word complete-word _expand_word_and_keep

-- 
Hannu

Re: _expand_word_and_keep of 'keeper suite' doesn't work

[Bart Schaefer]

On Dec 1, 11:57am, Hannu Koivisto wrote:
}
} The version of _expand_word_and_keep below (from the magazine
} article) doesn't seem to work in at least 4.2.5.  For some reason
} the condition [[ $args[-J] == all-expansions ]] is never true

The accept-exact and keep-prefix styles can cause _expand to skip
the call to compadd entirely, and styles that affect the value of
$compstate[insert] can cause it to skip the step that passes the -J
flag.  What are your zstyle settings?

Re: _expand_word_and_keep of 'keeper suite' doesn't work

[Hannu Koivisto]

Bart Schaefer <schaefer@brasslantern.com> writes:

> The accept-exact and keep-prefix styles can cause _expand to skip
> the call to compadd entirely, and styles that affect the value of
> $compstate[insert] can cause it to skip the step that passes the -J
> flag.  What are your zstyle settings?

These:

zstyle ':completion:*:cd:*' tag-order local-directories directories -
zstyle ':completion:all-matches:*' old-matches only
zstyle ':completion:all-matches::::' completer _all_matches

-- 
Hannu

Re: _expand_word_and_keep of 'keeper suite' doesn't work

[Bart Schaefer]

On Dec 2, 12:39am, Hannu Koivisto wrote:
} Subject: Re: _expand_word_and_keep of 'keeper suite' doesn't work
}
} Bart Schaefer <schaefer@brasslantern.com> writes:
} 
} > What are your zstyle settings?
} 
} These:

Hmm, none of those should have an adverse effect.  Try this:

autoload -U zed
Run "zed -f _complete_debug"
Scroll down to the line that reads "_main_complete"
Replace that with "_expand_word_and_keep"
Type ctrl-x ctrl-w to save

Now, set up an expansion of the sort that fails to work as expected,
but instead of your usual expand-word binding, type ctrl-x ?
(yes, that's ctrl-x followed by a question mark).

This should produce a trace file of the commands executed by the
completion system, which you can examine to see whether "compadd -J"
is ever being called.  If you can't see what's wrong, post it somewhere
accessible (or at worst, mail it to zsh-users) so we can have a look.
Make sure it doesn't contain any sensitive data, first, of course.

Re: _expand_word_and_keep of 'keeper suite' doesn't work

[Hannu Koivisto]

Bart Schaefer <schaefer@brasslantern.com> writes:

> This should produce a trace file of the commands executed by the
> completion system, which you can examine to see whether "compadd -J"
> is ever being called.  If you can't see what's wrong, post it somewhere
> accessible (or at worst, mail it to zsh-users) so we can have a look.

The trace file is now available at
<http://www.iki.fi/azure/completion-debug-output.txt>.  I can see
compadd calls with -J parameter but I don't know what to make of
those.  This is a bit too black magic to me.

-- 
Hannu

Re: _expand_word_and_keep of 'keeper suite' doesn't work

[Bart Schaefer]

On Dec 2,  9:40pm, Hannu Koivisto wrote:
}
} The trace file is now available at
} <http://www.iki.fi/azure/completion-debug-output.txt>.

OK, the first thing to try is:

  zstyle ':completion:*:expand:*' group-name ''

If that doesn't work, then it has to do with the way that you're binding
the _expand_word_and_keep function to a widget, because when I try it
(successfully) I consistently get a context of
    :completion:expand-word:expand:::
but your trace output shows a context of
    :completion::expand:::

Can you show me that part of your setup?

Re: _expand_word_and_keep of 'keeper suite' doesn't work

[Hannu Koivisto]

Bart Schaefer <schaefer@brasslantern.com> writes:

> OK, the first thing to try is:
>
>   zstyle ':completion:*:expand:*' group-name ''
>
> If that doesn't work, then it has to do with

It seems to work.  Does that have any adverse effects on other
functionality?

> the way that you're binding the _expand_word_and_keep function to
> a widget, because when I try it
...
> Can you show me that part of your setup?

I'm using the code from the article:

zle -C _expand_word complete-word _expand_word_and_keep

-- 
Hannu

Re: _expand_word_and_keep of 'keeper suite' doesn't work

[Bart Schaefer]

On Dec 3,  2:27pm, Hannu Koivisto wrote:
} Subject: Re: _expand_word_and_keep of 'keeper suite' doesn't work
}
} Bart Schaefer <schaefer@brasslantern.com> writes:
} 
} >   zstyle ':completion:*:expand:*' group-name ''
} 
} It seems to work.  Does that have any adverse effects on other
} functionality?

It changes the way the completion listing or the menuselect menu are
displayed, but only for expansion.  In fact, changing it everywhere by
    zstyle ':completion:*' group-name ''
is often a recommended setting even though it's not the default.

I'll have to see if I can tweak the keeper suite in the 4.3 dist so
that it works without the group-name setting, or at least document
that the above style is needed.
 
} > the way that you're binding the _expand_word_and_keep function to
} > a widget, because when I try it

This turns out to be a red herring from my own configuration, though
it does indicate another potentially useful change to keeper.

Re: _expand_word_and_keep of 'keeper suite' doesn't work

[Joakim Ryden]

I'm a lurker on this list, maybe a posting a year or two, but I have to 
say...and pardon my French...Dammit Bart, thank you so much for your 
posts, they are incredibly enlightening, patient, and useful to no end. 
Same goes for Peter. Thank you guys for making this list a sheer joy to 
read.

--Jo