PATCH: build zsh-5.8 on AIX 7.1

PATCH: build zsh-5.8 on AIX 7.1

[Peter A. Castro]

Greetings, All,

  Found I needed to build zsh on AIX 7.1 and found a few things needing
simple tweaks to make it compile/link.  I'm a little surprised some of
this hasn't bubbled up on other platforms, but AIX has always been a
little schizophrenic, so whatever.

  Also found you needed to set CC and CFLAGS thus:
  CC=xlc
  CFLAGS="-qlanglvl=stdc99"

Don't know where that knowledge should be placed, but most other compile
options (ie: cc, c98, etc) produce weird errors.  The above probably
needs to go into configure somewhere.

  Sorry about the diff output here.  AIX's diff is pretty limited.


diff -u Src/Zle/zle_main.c.orig Src/Zle/zle_main.c
--- Src/Zle/zle_main.c.orig	2021-08-25 13:34:08.000000000 -0700
+++ Src/Zle/zle_main.c	2021-08-25 13:34:46.000000000 -0700
@@ -1056,7 +1056,7 @@
  #endif
  
  /**/
- void
+ mod_export void
  redrawhook(void)
  {
      Thingy initthingy;
diff -u Src/Zle/zle_keymap.c.orig Src/Zle/zle_keymap.c
--- Src/Zle/zle_keymap.c.orig	2021-08-25 13:36:33.000000000 -0700
+++ Src/Zle/zle_keymap.c	2021-08-25 13:36:50.000000000 -0700
@@ -404,7 +404,7 @@
  /**************************/
  
  /**/
- Keymap
+ mod_export Keymap
  openkeymap(char *name)
  {
      KeymapName n = (KeymapName) keymapnamtab->getnode(keymapnamtab, name);
diff -u Src/Zle/zle_move.c.orig Src/Zle/zle_move.c
--- Src/Zle/zle_move.c.orig	2021-08-25 13:33:47.000000000 -0700
+++ Src/Zle/zle_move.c	2021-08-25 13:35:00.000000000 -0700
@@ -166,7 +166,7 @@
   */
  
  /**/
- char *
+ mod_export char *
  backwardmetafiedchar(char *start, char *endptr, convchar_t *retchr)
  {
  #ifdef MULTIBYTE_SUPPORT
diff -u Src/openssh_bsd_setres_id.c.orig Src/openssh_bsd_setres_id.c
--- Src/openssh_bsd_setres_id.c.orig	2021-08-25 12:43:24.000000000 -0700
+++ Src/openssh_bsd_setres_id.c	2021-08-25 12:43:36.000000000 -0700
@@ -46,6 +46,8 @@
   *
   */
  
+ #include "zsh.mdh"
+ #include "openssh_bsd_setres_id.pro"
  
  #include <sys/types.h>
  
@@ -52,8 +54,6 @@
  #include <stdarg.h>
  #include <unistd.h>
  #include <string.h>
- 
- #include "zsh.mdh"
  
  #if defined(ZSH_IMPLEMENT_SETRESGID) || defined(BROKEN_SETRESGID)
  int
diff -u Src/builtin.c.orig Src/builtin.c
--- Src/builtin.c.orig	2021-08-25 13:29:46.000000000 -0700
+++ Src/builtin.c	2021-08-25 13:30:16.000000000 -0700
@@ -2597,7 +2597,7 @@
   */
  
  /**/
- int
+ mod_export int
  bin_typeset(char *name, char **argv, LinkList assigns, Options ops, int func)
  {
      Param pm;

-- 
--=> Peter A. Castro
Email: doctor at fruitbat dot org / Peter dot Castro at oracle dot com
	"Cats are just autistic Dogs" -- Dr. Tony Attwood

Re: PATCH: build zsh-5.8 on AIX 7.1

[Peter Stephenson]

On Wed, 2021-08-25 at 14:55 -0700, Peter A. Castro wrote:
> Greetings, All,
> 
>   Found I needed to build zsh on AIX 7.1 and found a few things needing
> simple tweaks to make it compile/link.  I'm a little surprised some of
> this hasn't bubbled up on other platforms, but AIX has always been a
> little schizophrenic, so whatever.

Thanks, it looks like the mod_exports already made their way in, but
that fix to the .c file headers just makes it fit in with the others, so
thatʼs uncontroversial, too.

>   Also found you needed to set CC and CFLAGS thus:
>   CC=xlc
>   CFLAGS="-qlanglvl=stdc99"

This probably ought to go in the MACHINES file.  At the moment weʼre
claiming everything is fine everywhere, but thatʼs clearly not true
here.

Strictly this belongs on zsh-workers.

pws

Re: PATCH: build zsh-5.8 on AIX 7.1

[Peter A. Castro]

On Sat, Aug 28, 2021 at 09:41:57PM +0100, Peter Stephenson wrote:

Greetings, Peter :)

> On Wed, 2021-08-25 at 14:55 -0700, Peter A. Castro wrote:
> > Greetings, All,
> > 
> >   Found I needed to build zsh on AIX 7.1 and found a few things needing
> > simple tweaks to make it compile/link.  I'm a little surprised some of
> > this hasn't bubbled up on other platforms, but AIX has always been a
> > little schizophrenic, so whatever.
> 
> Thanks, it looks like the mod_exports already made their way in, but
> that fix to the .c file headers just makes it fit in with the others, so
> that??s uncontroversial, too.

Awesome.

> >   Also found you needed to set CC and CFLAGS thus:
> >   CC=xlc
> >   CFLAGS="-qlanglvl=stdc99"
> 
> This probably ought to go in the MACHINES file.  At the moment we??re
> claiming everything is fine everywhere, but that??s clearly not true
> here.
> 
> Strictly this belongs on zsh-workers.

I used to be subscribed to zsh-workers, but was getting so much email I
couldn't keep up with it.  Anyway, did you want a patch for MACHINES or
will you just put it in yourself?

> pws

-- 
--=> Peter A. Castro
Email: doctor at fruitbat dot org / Peter dot Castro at oracle dot com
	"Cats are just autistic Dogs" -- Dr. Tony Attwood

Re: PATCH: build zsh-5.8 on AIX 7.1

[Peter Stephenson]

On Mon, 2021-08-30 at 12:17 -0700, Peter A. Castro wrote:
> On Sat, Aug 28, 2021 at 09:41:57PM +0100, Peter Stephenson wrote:
> I used to be subscribed to zsh-workers, but was getting so much email I
> couldn't keep up with it.  Anyway, did you want a patch for MACHINES or
> will you just put it in yourself?

A patch would be useful, we can adapt if necessary.  Details of the OS
version will be helpful --- you don't need to do any archaeology, it's
just so we know the current version with the comment against it.

Cheers
pws