zsh-users
 help / color / mirror / code / Atom feed
* Gentoo startup bug
@ 2012-10-24 14:25 ☈king
  2012-10-24 15:00 ` Damien Thébault
  0 siblings, 1 reply; 6+ messages in thread
From: ☈king @ 2012-10-24 14:25 UTC (permalink / raw)
  To: zsh-users

Is anyone here in any way connected to the Gentoo package maintenance team?

I could use some help getting a response out of them regarding this bug:

  https://bugs.gentoo.org/show_bug.cgi?id=19924

The solution is obvious: What they installed as /etc/zsh/zprofile is
supposed to be /etc/zsh/zshenv.

I'm tired of losing my $path every time I upgrade zsh on Gentoo.

Thanks!
—☈



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Gentoo startup bug
  2012-10-24 14:25 Gentoo startup bug ☈king
@ 2012-10-24 15:00 ` Damien Thébault
  2012-10-24 15:08   ` ☈king
  0 siblings, 1 reply; 6+ messages in thread
From: Damien Thébault @ 2012-10-24 15:00 UTC (permalink / raw)
  To: ☈king; +Cc: zsh-users

On Wed, Oct 24, 2012 at 4:25 PM, ☈king <rkingdesk@sharpsaw.org> wrote:
> Is anyone here in any way connected to the Gentoo package maintenance team?
>
> I could use some help getting a response out of them regarding this bug:
>
>   https://bugs.gentoo.org/show_bug.cgi?id=19924
>
> The solution is obvious: What they installed as /etc/zsh/zprofile is
> supposed to be /etc/zsh/zshenv.
>
> I'm tired of losing my $path every time I upgrade zsh on Gentoo.

I guess you could talk to the current maintainers of this package:
http://euscan.iksaif.net/package/app-shells/zsh/

But the solution doesn't seem simple, the bug have 35 comments. I
think that a proposal should summarize the issues and explain the
change.

Regards,
-- 
Damien Thebault


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Gentoo startup bug
  2012-10-24 15:00 ` Damien Thébault
@ 2012-10-24 15:08   ` ☈king
  2012-10-25 17:00     ` Bernd Steinhauser
  0 siblings, 1 reply; 6+ messages in thread
From: ☈king @ 2012-10-24 15:08 UTC (permalink / raw)
  To: Damien Thébault; +Cc: zsh-users

On 10/24/2012 10:00 AM, Damien Thébault wrote:
> I guess you could talk to the current maintainers of this package:
> http://euscan.iksaif.net/package/app-shells/zsh/

Yes, sent them a ping.

> But the solution doesn't seem simple, the bug have 35 comments. I
> think that a proposal should summarize the issues and explain the
> change.

https://bugs.gentoo.org/show_bug.cgi?id=19924#c33

That seems like a simple, correct solution, and it has worked fine for
me every time I've upgraded zsh on Gentoo since I've known about it.

The part I'm 100% sure about is that they're resetting $path after the
user's ~/.zshenv has run. That's wrong.

—☈


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Gentoo startup bug
  2012-10-24 15:08   ` ☈king
@ 2012-10-25 17:00     ` Bernd Steinhauser
  2012-10-26  8:42       ` Peter Stephenson
  0 siblings, 1 reply; 6+ messages in thread
From: Bernd Steinhauser @ 2012-10-25 17:00 UTC (permalink / raw)
  To: zsh-users

On 24/10/12 17:08, ☈king wrote:
> On 10/24/2012 10:00 AM, Damien Thébault wrote:
>> I guess you could talk to the current maintainers of this package:
>> http://euscan.iksaif.net/package/app-shells/zsh/
> Yes, sent them a ping.
>
>> But the solution doesn't seem simple, the bug have 35 comments. I
>> think that a proposal should summarize the issues and explain the
>> change.
> https://bugs.gentoo.org/show_bug.cgi?id=19924#c33
>
> That seems like a simple, correct solution,
Mind if I ask how you come to that conclusion?
>   and it has worked fine for
> me every time I've upgraded zsh on Gentoo since I've known about it.
That's not really an appropriate way to find a correct solution. "It works" 
might be very far away from "It is correct".
> The part I'm 100% sure about is that they're resetting $path after the
> user's ~/.zshenv has run. That's wrong.
I didn't look at Gentoo's zprofile in a few years, but even if (for whatever 
reason), they would reset $path after ~/.zshenv has run I highly doubt that your 
solution is desirable (Actually, it might be desirable to reset $path, because 
it affects `zsh -f`, but I didn't invest a lot of thought into that one.).
Most likely, you misunderstood or misinterpreted what zshenv is for. There have 
been discussions about that topic zshenv vs. zshrc vs. zprofile on the zsh 
lists, you might want to search the archives for that (also look at zsh's manpage).
Or mind if I ask why you set your user changes of $path in ~/.zshenv rather than 
~/.zshrc (where it should be set, since you want it in interactive shells).
Actually, if you move the global zprofile to zshenv, it is very likely, that 
zsh's tests fail, but then, tests are not run on gentoo by default, so most 
likely you wouldn't notice that.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Gentoo startup bug
  2012-10-25 17:00     ` Bernd Steinhauser
@ 2012-10-26  8:42       ` Peter Stephenson
  2012-10-27 15:29         ` Bernd Steinhauser
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Stephenson @ 2012-10-26  8:42 UTC (permalink / raw)
  To: zsh-users

On 25 October 2012 18:00, Bernd Steinhauser <linux@bernd-steinhauser.de> wrote:
> I didn't look at Gentoo's zprofile in a few years, but even if (for whatever
> reason), they would reset $path after ~/.zshenv has run I highly doubt that
> your solution is desirable (Actually, it might be desirable to reset $path,
> because it affects `zsh -f`, but I didn't invest a lot of thought into that
> one.).
> Most likely, you misunderstood or misinterpreted what zshenv is for. There
> have been discussions about that topic zshenv vs. zshrc vs. zprofile on the
> zsh lists, you might want to search the archives for that (also look at
> zsh's manpage).
> Or mind if I ask why you set your user changes of $path in ~/.zshenv rather
> than ~/.zshrc (where it should be set, since you want it in interactive
> shells).

Without going into the details, there are perfectly good reasons for
putting your path in .zshenv, such as having the same path in all
instances of the shell.

The main point is there's really no good argument for a distribution to trash
a user's path.  You simply can't guess how the many users of many different
types are going to use the shell. I agree this bit is definitely
wrong. It's a very
different argument from, say, a specific site where you expect users to
conform to a certain way of doing things.

pws


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Gentoo startup bug
  2012-10-26  8:42       ` Peter Stephenson
@ 2012-10-27 15:29         ` Bernd Steinhauser
  0 siblings, 0 replies; 6+ messages in thread
From: Bernd Steinhauser @ 2012-10-27 15:29 UTC (permalink / raw)
  To: zsh-users

On 26/10/12 10:42, Peter Stephenson wrote:
> Without going into the details, there are perfectly good reasons for
> putting your path in .zshenv, such as having the same path in all
> instances of the shell.
Probably. The problem I see is that it might also lead to unexpected behavior, 
for example if you run a script using
PATH=/some/path:$PATH zsh -f somescript

If zprofile resets the path, then moving it to zshenv will reset it in any case. 
So it might be an improvement if a user really wants to set PATH in .zshenv, but 
in other cases, it might make things worse.
I'm not sure about the correct solution. Maybe setting PATH in .zshenv, but only 
if it has not been set?
>
> The main point is there's really no good argument for a distribution to trash
> a user's path.  You simply can't guess how the many users of many different
> types are going to use the shell. I agree this bit is definitely
> wrong. It's a very
> different argument from, say, a specific site where you expect users to
> conform to a certain way of doing things.
My point was, that simply moving zprofile to zshenv is a bad idea, since zshenv 
should be kept very minimalistic and zprofile might do more stuff than just 
setting PATH. So even if PATH should be set in zshenv, then maybe the file 
should be split up instead. In addition, the problem isn't really "where" PATH 
is reset, but that it is reset.
I just wanted to point out that the simplest solution might not be the best 
solution.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-10-27 15:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-24 14:25 Gentoo startup bug ☈king
2012-10-24 15:00 ` Damien Thébault
2012-10-24 15:08   ` ☈king
2012-10-25 17:00     ` Bernd Steinhauser
2012-10-26  8:42       ` Peter Stephenson
2012-10-27 15:29         ` Bernd Steinhauser

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).