From: John <jmharres@gmail.com>
To: zsh-users@zsh.org
Subject: Re: ordering of file-patterns completions
Date: Wed, 06 Nov 2013 23:30:02 -0700 [thread overview]
Message-ID: <527B336A.40506@gmail.com> (raw)
In-Reply-To: <131106201745.ZM20201@torch.brasslantern.com>
On 11/6/13, 9:17 PM, Bart Schaefer wrote:
> On Nov 6, 6:11pm, John wrote:
> }
> } > doesn't quite generalize if there may be options (words starting with
> } > a hyphen) between the command name and the first file. If that is the
> } > case, you'll need to do some pre-processing of $words before calling
> } > _arguments to determine which position to reference instead of [2].
> }
> } Yeah, unfortunately I do. I was using _arguments to process those, and
> } then zstyle to deal with the files. But I'm not quite understanding how
> } to do what you're describing to pre-process them instead of using
> } _arguments.
>
> How complicated this needs to be depends on what might appear in the
> words preceding the first file.
>
> If there's nothing but options, for example, then you can probably do:
>
> local first_file=$(( ${words[(I)-*]} + 1 ))
>
> which says to start from the end of the array and look backward to
> find the index of the first word that DOES start with a hyphen, and
> then add one to it. Or, if there might be file names that start with
> hyphen, then:
>
> local first_file=$(( ${${words[2,-1]}[(i)[^-]*]} + 1 ))
>
> which says "in the array formed by the second through last elements of
> the words array, report the index of the first element that does not
> begin with a hyphen" and then add one to compensate for starting at 2.
>
The first one nearly does it, but seems to be confused when there are no
options at all. That is, it works fine as long as there is a --opt1,
but if there isn't, the *: portion says it's completing the right thing,
but then lists all the files rather than the matching one:
% yes <tab>XXX.<tab>
Completing XXX file
XXX.0 XXX.bogus XXX.bogus3
XXX.1 XXX.bogus2 XXX.bogus4
% yes --opt1 XXX.0 <tab>XXX-YYY.0
% yes XXX.0 XXX<tab>
Completing XXX extra files
XXX-YYY.0 XXX.0 XXX.bogus XXX.bogus3
XXX-YYY.1 XXX.1 XXX.bogus2 XXX.bogus4
This is with:
#compdef yes
local first_file=$(( ${words[(I)--*]} + 1 ))
_arguments \
'--opt1[desc1]' \
'--opt2[desc2]' \
'1:XXX file:_files -g "*XXX.*"' \
'*:XXX extra files:_files -g "*XXX-*.${words[first_file]:e}"'
I ended up adding:
if [[ $first_file -lt 2 ]]; then
first_file=2
fi
And that fixed it. Not realizing that the array was 1-based threw me
for a bit. I also changed the :x to a :e, as :x just gave me an error,
and :e matched the description of what I think you had meant.
Thanks!
John
next prev parent reply other threads:[~2013-11-07 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 15:24 John
2013-11-06 16:03 ` Bart Schaefer
2013-11-07 1:11 ` John
2013-11-07 4:17 ` Bart Schaefer
2013-11-07 6:30 ` John [this message]
2013-11-07 15:06 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527B336A.40506@gmail.com \
--to=jmharres@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).