Compilation failure for zsh-5.0.5

Compilation failure for zsh-5.0.5

[Bernd Steinhauser]

Hi,

when trying to compile the latest zsh version 5.0.5, I get the following error:
make[3]: Entering directory 
`/var/tmp/paludis/build/app-shells-zsh-5.0.5/work/zsh-5.0.5/Src/Modules'
x86_64-pc-linux-gnu-gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  
-DHAVE_CONFIG_H -DMODULE -march=amdfam10 -O2 -pipe -fPIC -o attr..o attr.c
In file included from /usr/include/sys/capability.h:30:0,
                  from ../../Src/zsh_system.h:510,
                  from ../../Src/zsh.mdh:17,
                  from attr.mdh:17,
                  from attr.c:30:
/usr/include/sys/xattr.h:31:3: error: expected identifier before numeric constant
    XATTR_CREATE = 1, /* set value, fail if attr already exists.  */
    ^
make[3]: Leaving directory 
`/var/tmp/paludis/build/app-shells-zsh-5.0.5/work/zsh-5.0.5/Src/Modules'
make[2]: Leaving directory 
`/var/tmp/paludis/build/app-shells-zsh-5.0.5/work/zsh-5.0.5/Src'
make[1]: Leaving directory 
`/var/tmp/paludis/build/app-shells-zsh-5.0.5/work/zsh-5.0.5/Src'
make[3]: *** [attr..o] Error 1
make[2]: *** [modules] Error 1
make[1]: *** [modules] Error 2
make: *** [all] Error 1


The used glibc version is 2.17. Anyone can help?

Regards,
Bernd

Re: Compilation failure for zsh-5.0.5

[Bart Schaefer]

On Jan 10, 11:05pm, Bernd Steinhauser wrote:
}
} In file included from /usr/include/sys/capability.h:30:0,
}                   from ../../Src/zsh_system.h:510,
}                   from ../../Src/zsh.mdh:17,
}                   from attr.mdh:17,
}                   from attr.c:30:
} /usr/include/sys/xattr.h:31:3: error: expected identifier before numeric constant
}     XATTR_CREATE = 1, /* set value, fail if attr already exists.  */
}     ^
} [...]
} 
} The used glibc version is 2.17. Anyone can help?

That error is coming from a system-level header file ... we need to know
not just the glibc version, but the compiler and also operating system you
are compiling on, whether you're cross-compiling for something else, etc.

Even then our ability to help will be determined by whether we have a
similar platform to try out.

Re: Compilation failure for zsh-5.0.5

[Bernd Steinhauser]

On 11/01/14 00:55, Bart Schaefer wrote:
> On Jan 10, 11:05pm, Bernd Steinhauser wrote:
> }
> } In file included from /usr/include/sys/capability.h:30:0,
> }                   from ../../Src/zsh_system.h:510,
> }                   from ../../Src/zsh.mdh:17,
> }                   from attr.mdh:17,
> }                   from attr.c:30:
> } /usr/include/sys/xattr.h:31:3: error: expected identifier before numeric constant
> }     XATTR_CREATE = 1, /* set value, fail if attr already exists.  */
> }     ^
> } [...]
> }
> } The used glibc version is 2.17. Anyone can help?
>
> That error is coming from a system-level header file ... we need to know
> not just the glibc version, but the compiler and also operating system you
> are compiling on, whether you're cross-compiling for something else, etc.
>
> Even then our ability to help will be determined by whether we have a
> similar platform to try out.
>
Operating System is Exherbo Linux with kernel 3.13.0-rc7 running on amd64:
uname -a
Linux orionis 3.13.0-rc7 #1 SMP PREEMPT Tue Jan 7 23:45:18 CET 2014 x86_64 GNU/Linux

There is no cross compiling, I'm compiling on this computer for exactly this 
platform and this computer. I didn't do any special setup for the build 
environment, just ran configure (without any options) and make.

compiler:
gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/4.8.2/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: 
/var/tmp/paludis/build/sys-devel-gcc-4.8.2-r2/work/gcc-4.8.2/configure 
--prefix=/usr --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu 
--mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share 
--sysconfdir=/etc --localstatedir=/var/lib --disable-silent-rules 
--enable-fast-install --libdir=/usr/lib64 --cache-file=config.cache 
--libdir=/usr/lib64 --with-pkgversion='exherbo gcc-4.8.2-r2' 
--program-suffix=-4.8 --disable-bootstrap --enable-clocale=gnu 
--enable-languages=c,c++,fortran,objc,obj-c++ --enable-lto --enable-multilib 
--enable-nls --enable-serial-configure --enable-libquadmath 
--enable-libquadmath-support --without-cloog --enable-libgomp --disable-libobjc 
--disable-libssp --with-as=x86_64-pc-linux-gnu-as 
--with-ld=x86_64-pc-linux-gnu-ld --with-system-zlib
Thread model: posix
gcc version 4.8.2 (exherbo gcc-4.8.2-r2)

In case this might be useful, binutils is version 2.24. Linux headers are from 3.12.

Currently, I have zsh 5.0.2 installed, which was built using gcc 4.7 and glibc 
2.17. So this might be related to the new gcc (4.8) I have installed since 2 
approx. weeks. Unfortunately, I removed the old gcc already, otherwise I would 
just check with that one and see if it compiles.
I also noticed that glibc 2.17 has been build with gcc 4.7, no idea if that 
might be important. I will try to build it with the newer one and check if that 
helps.

Re: Compilation failure for zsh-5.0.5

[Jun T.]

Similar problem is reported here:
https://bugs.archlinux.org/task/38387

Please try #include "attr.mdh" after <sys/xattr.h>.
Or try {up,down}grading libcap.

Re: Compilation failure for zsh-5.0.5

[Bart Schaefer]

On Jan 11,  9:58am, Bernd Steinhauser wrote:
}
} > That error is coming from a system-level header file ... we need to know
} > not just the glibc version, but the compiler and also operating system
} >
} Operating System is Exherbo Linux with kernel 3.13.0-rc7 running on amd64:

www.exherbo.org:

    "We need the freedom to break things when necessary."

Looks like perhaps they did?  <grin>

Anybody out there got an install of this they can test with?  There's
no prebuilt image or "live cd" I can find except for a KVM virtual
guest (and I don't have KVM).  Maybe I'm just not looking hard enough.

Re: Compilation failure for zsh-5.0.5

[Bernd Steinhauser]

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On 11/01/14 19:07, Bart Schaefer wrote:
> On Jan 11,  9:58am, Bernd Steinhauser wrote:
> }
> } > That error is coming from a system-level header file ... we need to know
> } > not just the glibc version, but the compiler and also operating system
> } >
> } Operating System is Exherbo Linux with kernel 3.13.0-rc7 running on amd64:
>
> www.exherbo.org:
>
>      "We need the freedom to break things when necessary."
>
> Looks like perhaps they did?  <grin>
Not this time. ;)
Apart from that, we do have almost no distribution-specific breakage, as we try 
to stick to upstream as close as possible when packaging.
> Anybody out there got an install of this they can test with?  There's
> no prebuilt image or "live cd" I can find except for a KVM virtual
> guest (and I don't have KVM).  Maybe I'm just not looking hard enough.
Apparently, it seems to be bug in glibc, which is fixed in 2.18. So the proper 
solution is to upgrade to that or patch glibc if a patch is available (which 
other distributions might have done, so they don't see that problem).
The patch below after the hint of Jun Takimoto is a workaround (had to move both 
includes), but the root of the problem seems to be in glibc. So it shouldn't be 
necessary to patch zsh.

Thank for the help.


[-- Attachment #2: 0001-Move-includes-to-fix-compilation-failure.patch --]
[-- Type: text/x-patch, Size: 720 bytes --]

>From 22fdc8c0bf640557ae06dd609fd3ca0a65176947 Mon Sep 17 00:00:00 2001
From: Bernd Steinhauser <berniyh@exherbo.org>
Date: Sun, 12 Jan 2014 12:00:22 +0100
Subject: [PATCH] Move includes to fix compilation failure.

---
 Src/Modules/attr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Src/Modules/attr.c b/Src/Modules/attr.c
index 6e08b10..b57874e 100644
--- a/Src/Modules/attr.c
+++ b/Src/Modules/attr.c
@@ -27,12 +27,13 @@
  *
  */
 
-#include "attr.mdh"
-#include "attr.pro"
 
 #include <sys/types.h>
 #include <sys/xattr.h>
 
+#include "attr.mdh"
+#include "attr.pro"
+
 static ssize_t
 xgetxattr(const char *path, const char *name, void *value, size_t size, int symlink)
 {
-- 
1.8.5.2