zsh-users
 help / color / mirror / code / Atom feed
From: "Lawrence Velázquez" <vq@larryv.me>
To: Ray Andrews <rayandrews@eastlink.ca>
Cc: zsh-users@zsh.org
Subject: Re: protect spaces and/or globs
Date: Thu, 11 Feb 2021 12:19:06 -0500	[thread overview]
Message-ID: <544A50D4-7F71-4763-8DEC-D5D99E4AE7CC@larryv.me> (raw)
In-Reply-To: <8a718224-f0e4-d960-1d65-f600ec818415@eastlink.ca>

> On Feb 11, 2021, at 11:31 AM, Ray Andrews <rayandrews@eastlink.ca> wrote:
> 
>   while [[ $# -gt 0 ]] ; do
>     arg="$1"
>     shift
>       grepargs+=( "$arg" )
>   done

Why are you still accreting grepargs like this? Peter has already
shown you how to do this.

	grepargs=("$@")

Unless your actual code actually modifies the args before adding
them to the array?

> Seems cleaner, the single quotes are themselves protected or replaced so that
> it not only runs right, it looks right; on recall it is  visually exactly the same.

The command saved to history is correct, but it is not always exactly
what you entered.

	% grep_wrapper on\ the\ current i,2,light\ edit i,1,old\ stable 

	what should be going to history:
	grep --color=always -i -- 'on the current' 'i,2,light edit' 'i,1,old stable'

	[...]

	% pat='on the current' foo='i,2,light edit' bar='i,1,old stable'
	% grep_wrapper $pat $foo $bar

	what should be going to history:
	grep --color=always -i -- 'on the current' 'i,2,light edit' 'i,1,old stable'

	[...]

A ${(q-)foo} expansion basically re-quotes the value of foo so
it works correctly with eval, in whatever way is requested. It
doesn't know the value's origins.

> And is it not intuitive that, since single quotes already
> protect their string, if you add protection for the single
> quotes themselves, you then have a perfectly protected string?

That's not how quoting works. Quote levels don't nest to produce
some kind of super-quoting. You're misinterpreting the results of
your experimentation.

	% foo='a b c'
	% print -r 'protected: $foo'
	protected: $foo
	% print -r "'not protected: $foo'"
	'not protected: a b c'

The double quotes do protect the single quotes from being interpreted
by the shell, but they also permit expansions.

vq

  reply	other threads:[~2021-02-11 17:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 20:42 Ray Andrews
2021-02-09 21:05 ` Lawrence Velázquez
2021-02-09 21:08 ` Peter Stephenson
2021-02-09 23:45   ` Ray Andrews
2021-02-10  0:22     ` Lawrence Velázquez
2021-02-10  0:51       ` Ray Andrews
2021-02-10  1:46         ` Lawrence Velázquez
2021-02-10  2:25           ` Ray Andrews
2021-02-10  2:52             ` Lawrence Velázquez
2021-02-10  1:52         ` Greg Klanderman
2021-02-10  2:29           ` Ray Andrews
2021-02-10 15:18           ` Ray Andrews
2021-02-10 15:47             ` Peter Stephenson
2021-02-10 16:19               ` Ray Andrews
2021-02-10 16:29                 ` Peter Stephenson
2021-02-10 20:53                   ` Ray Andrews
2021-02-10 22:14                     ` Bart Schaefer
2021-02-11 16:31                       ` Ray Andrews
2021-02-11 17:19                         ` Lawrence Velázquez [this message]
2021-02-11 19:48                           ` Ray Andrews
2021-02-10 18:08                 ` Bart Schaefer
2021-02-10 20:56                   ` Ray Andrews
2021-02-10 16:28             ` Lawrence Velázquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544A50D4-7F71-4763-8DEC-D5D99E4AE7CC@larryv.me \
    --to=vq@larryv.me \
    --cc=rayandrews@eastlink.ca \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).