zsh-users
 help / color / mirror / code / Atom feed
From: Eric Cook <llua@gmx.com>
To: zsh-users@zsh.org
Subject: Re: Seeking feedback word breaks and aliasing of tokens
Date: Sun, 29 Mar 2015 13:09:41 -0400	[thread overview]
Message-ID: <551831D5.9080007@gmx.com> (raw)
In-Reply-To: <150328211913.ZM6831@torch.brasslantern.com>

On 03/29/2015 12:19 AM, Bart Schaefer wrote:
> On Mar 28,  7:58pm, Eric Cook wrote:
> }
> } It personally looks weird to me on first glance and i wouldn't expect it
> } to work like that, but i do not oppose the change.
>
> Sorry, could you clarify which thing looks weird to you?
The additional effect example is what looks weird to me. I was mostly
curious how it would affect completion that relys on $words or $service
since with {-<tab> or {subcommand <tab> there would only be one word on
the line. But i was reminded in IRC that aliases expand before compsys runs.
>
> } Also, compsys doesn't seem to like it currently:
> } alias \{=echo
> } {<tab> # segfaults zsh currently (not sure if someone else brought it up
> } in the original thread)
>
> Again I'm not sure precisely what "it" means, but *without* my patch from
> workers/34781, I get this:
>
> torch% alias \{=echo
> torch% {<TAB>
> zle_tricky.c:668: BUG: 0 <= wb (-3) <= zlemetacs (1) <= we (1) is not true!
> Program received signal SIGSEGV, Segmentation fault.
> (gdb) where 3
> #0  0x080cdb32 in ztrsub (t=0x8b48a35 "", 
>     s=0x8b74001 <Address 0x8b74001 out of bounds>)
>     at ../../zsh-5.0/Src/utils.c:4491
> #1  0x081334ab in docomplete (lst=0)
>     at ../../../zsh-5.0/Src/Zle/zle_tricky.c:675
> #2  0x081328a9 in completeword (args=0x8171b60)
>     at ../../../zsh-5.0/Src/Zle/zle_tricky.c:232
> (gdb) up
> #1  0x081334ab in docomplete (lst=0)
>     at ../../../zsh-5.0/Src/Zle/zle_tricky.c:675
> 675         if (viinsbegin > ztrsub(zlemetaline + wb, zlemetaline))
>
> *With* 34781, there is no "BUG:" or segmentation fault.  So I think that
> is justification enough to commit it, and we can revisit if necessary.
... and that was "it". I tried a build before a commit referencing
workers/34781 was made, ZSH_PATCHLEVEL was zsh-5.0.7-362-gab40656. sorry
about that :D


  parent reply	other threads:[~2015-03-29 17:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 16:05 Bart Schaefer
2015-03-28 23:58 ` Eric Cook
2015-03-29  4:19   ` Bart Schaefer
2015-03-29  4:47     ` Bart Schaefer
2015-03-29 17:09     ` Eric Cook [this message]
2015-03-29 21:02       ` Bart Schaefer
2015-05-15  0:41 ` Oliver Kiddle
2015-05-15  1:35   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551831D5.9080007@gmx.com \
    --to=llua@gmx.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).