zsh-users
 help / color / mirror / code / Atom feed
From: Andrew Janke <janke@pobox.com>
To: Peter Stephenson <p.stephenson@samsung.com>,
	 Zsh Users <zsh-users@zsh.org>
Subject: Re: Three-byte UTF-8 chars and $functions
Date: Sat, 06 Jun 2015 02:40:51 -0400	[thread overview]
Message-ID: <557295F3.8040303@pobox.com> (raw)
In-Reply-To: <20150529121246.5d13e349@pwslap01u.europe.root.pri>

That fixes it for me on OS X 10.9. (Sorry I didn't see this earlier; 
victim of an overzealous mail filter.)

Thanks!

Andrew

On 5/29/15 7:12 AM, Peter Stephenson wrote:
> On Thu, 28 May 2015 18:05:35 -0400
> Andrew Janke <janke@pobox.com> wrote:
>> I'm seeing some odd behavior related to multibyte UTF-8 characters that
>> I don't understand. Maybe one of you could help me figure out? I don't
>> know if it's user error, incorrect behavior expectations on my part, or
>> an actual character handling issue.
> It's what we call "a bug".
>
> You may not have heard the expression before as it doesn't happen that
> much round here.
>
> Sigh.
>
>> function foo () { echo '▸' }
>>
>> # But capture their string representations...
>> foo_str="${functions[foo]}"
>>
>> # ...and in those strings, I see foo as 2 chars longer than bar
> You know when you see something funny in a function and you're too
> cowardly to change it so you just stick a comment about it there and
> forget about it?  This happens.
>
> See if there are still any remaining problems.
>
> pws
>
> diff --git a/Src/Modules/parameter.c b/Src/Modules/parameter.c
> index 55157a9..04d4485 100644
> --- a/Src/Modules/parameter.c
> +++ b/Src/Modules/parameter.c
> @@ -410,11 +410,6 @@ getfunction(UNUSED(HashTable ht), const char *name, int dis)
>   	    } else
>   		h = dyncat(start, t);
>   	    zsfree(t);
> -	    /*
> -	     * TBD: Is this unmetafy correct?  Surely as this
> -	     * is a parameter value it stays metafied?
> -	     */
> -	    unmetafy(h, NULL);
>   
>   	    if (shf->redir) {
>   		t = getpermtext(shf->redir, NULL, 1);


      reply	other threads:[~2015-06-06  6:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 22:05 Andrew Janke
2015-05-29 11:12 ` Peter Stephenson
2015-06-06  6:40   ` Andrew Janke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557295F3.8040303@pobox.com \
    --to=janke@pobox.com \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).