From: Motoi Washida <a66@h8.dion.ne.jp>
To: lists <lists@kalama.no-ip.org>
Cc: zsh-users@sunsite.dk
Subject: Re: Darwin _defaults completion bug
Date: Fri, 18 Feb 2005 15:55:53 +0900 [thread overview]
Message-ID: <625fad5460dfb26c51c4ddd080945bf5@h8.dion.ne.jp> (raw)
In-Reply-To: <bb57a9a834f9731d92eac69b1260728e@kalama.no-ip.org>
Hi Ryan,
> I think I've found a small bug with your _defaults completion (which
> I use all the time). If I type 'defaults read -g' then hit the Tab
> key, I see a list of possible completions which are quoted *and*
> escaped with a backslash.
(...snip...)
> ...et cetera, et cetera. The command doesn't work in the escaped +
> quoted form. If just the quotes are used, the command works. I've
> looked at _defaults but haven't been able to figure out where the
> escapes are being inserted. If you get a chance, could you take a
> look?
Thanks! This occurred because the completion did not handle quoted key
name "defaults read" prints. Here is a patch to remove quotes.
--
Motoi Washida
Index: Completion/Darwin/Command/_defaults
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Darwin/Command/_defaults,v
retrieving revision 1.2
diff -d -u -r1.2 _defaults
--- Completion/Darwin/Command/_defaults 17 Jan 2005 09:39:21 -0000 1.2
+++ Completion/Darwin/Command/_defaults 18 Feb 2005 06:24:58 -0000
@@ -14,9 +14,10 @@
}
_defaults_keys(){
- local ks="$(_call_program keys defaults read "$words[2]" 2>/dev/null
| sed '/^ [[:alpha:]"]/ { s/^ //; s/ = .*$//; p;}; d')"
+ local ks
+ ks=(${${${${(M)${(f)"$(defaults read "$words[2]" 2>/dev/null)"}:#
[^ ]*=*}# }%% = *}:Q})
local expl
- _wanted keys expl 'key' compadd ${(f)ks}
+ _wanted keys expl 'key' compadd "$ks[@]"
}
_defaults(){
next prev parent reply other threads:[~2005-02-18 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-04 4:45 lists
2005-02-18 6:55 ` Motoi Washida [this message]
2005-02-18 14:22 ` lists
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=625fad5460dfb26c51c4ddd080945bf5@h8.dion.ne.jp \
--to=a66@h8.dion.ne.jp \
--cc=lists@kalama.no-ip.org \
--cc=zsh-users@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).