zsh-users
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-users@sunsite.dk
Subject: Re: trap for EXIT doesn't catch exit?
Date: Tue, 18 Sep 2001 12:28:10 +0100	[thread overview]
Message-ID: <674.1000812490@csr.com> (raw)
In-Reply-To: "Michal Vitecek"'s message of "Tue, 18 Sep 2001 13:14:16 +0200." <20010918131416.A13937@fuf.sh.cvut.cz>

Michal Vitecek wrote:
>  in one of my zsh programs i'm creating a number of temporary files which
>  should be removed when the program execution stops or an error occurs
>  and i call 'exit'.
> 
>  however after having specified 'trap CleanUp EXIT' the clean-up
>  function is not called when 'exit' inside a function is executed.
>
>  an example program (test.sh):
>  ----start----
>     #!/bin/zsh
> 
>     function CleanUp()
>     {
> 	  rm -f tempfile
>     } 
> 
>     function WillExit()
>     {
> 	  exit
>     }
> 
> 
>     trap CleanUp EXIT
>     touch tempfile
>     WillExit
>  ----end----
> 
>  $ chmod +x test.sh
>  $ ./test.sh
>  $ ls tempfile
>  tempfile
>  $

Yes, that certainly looks like a bug.

What's happening is this: when you enter the function WillExit, it saves
the trap for exiting the shell and resets the trap, so that if you set a
trap for EXIT it applies on to the function, not the shell.  Usually it
would restore this when the function exits.  However, when you call `exit',
it simply exits the shell without exiting the function scope.  So it never
sees the trap EXIT set for exiting the shell.

Probably the correct thing to do here is to pop all the saved EXIT's off
the stack of saved traps, executing them one by one, to simulate exiting
the scope of each function in turn.  I'll wait to see if there are comments
before I do that (further discussion should probably go to zsh-workers).

A temporary workaround is to install `trap CleanUp Exit' inside WillExit.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************


      reply	other threads:[~2001-09-18 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-18 11:14 Michal Vitecek
2001-09-18 11:28 ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=674.1000812490@csr.com \
    --to=pws@csr.com \
    --cc=zsh-users@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).