From: "Com MN PG P E B Consultant 3" <mn-pg-p-e-b-consultant-3.com@siemens.com>
To: "zsh-users Mailinglist" <zsh-users@sunsite.dk>
Subject: Can I do without "eval" here?
Date: Tue, 14 Mar 2006 10:03:51 +0100 [thread overview]
Message-ID: <6F0CB04509C11D46A54232E852E390AC01004881@MCHP7R6A.ww002.siemens.net> (raw)
Maybe just a matter of style, but here is a (simplified) version of a
problem which
I have solved, but where I am not satisfied with the solution ...
Assume I have a command CMD which can be called in the following ways:
CMD -x FILENAME
CMD -y 'this is some string with alphanumerics and spaces' FILENAME
I call this CMD from a skript MYSCRIPT. If the skript is called with 1
parameter, I use the second form and put the
parameter into the argument of my -y option. If MYSCRIPT is called
without parameters, I use the -x option.
For sake of simplicity, we can assume that the FILENAME is always
hardcoded. That is, if someone calls
MYSCRIPT without any arguments, i.e.
MYSCRIPT
it should execute
CMD -x foo
But if MYSCRIPT is called like this:
MYSCRIPT "bar baz"
it should execute
CMD -y 'bar baz' foo
Here is my solution (which I ask you to improve):
#!/bin/zsh
if [[ $# -eq 0 ]]
then
options=-x
else
options="-y '$1'"
fi
eval CMD $options foo
The 'eval' is necessary here, because if I write just
CMD $options foo
CMD would see for example -y 'bar baz' as first argument, and not just
-y.
What I don't like in this example, is the usage of eval. Although it is
harmless in this particular case,
the filename 'foo', which is hardcoded here, comes in as a parameter too
in my real application, and
this means that it undergoes one level of evaluation too, which would
yield wrong results when it contains,
say, a $ character.
Of course one might argued that when you are thinking of filenames with
$, you are doomed anyway, but
still I'm not a big fan of using 'eval' anyway, so I wonder whether this
can be done without eval
too....
Ronald
next reply other threads:[~2006-03-14 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-14 9:03 Com MN PG P E B Consultant 3 [this message]
2006-03-14 9:16 ` DervishD
2006-03-14 9:22 ` Michal Politowski
2006-03-14 9:42 ` DervishD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6F0CB04509C11D46A54232E852E390AC01004881@MCHP7R6A.ww002.siemens.net \
--to=mn-pg-p-e-b-consultant-3.com@siemens.com \
--cc=zsh-users@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).