From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: zsh-users@zsh.org
Subject: Re: ${(z)} parsing of multiple array assignments
Date: Tue, 31 Dec 2019 11:58:46 +0000 [thread overview]
Message-ID: <7c671a8a-d6da-49ca-b3c8-4d9b26e462af@www.fastmail.com> (raw)
In-Reply-To: <3cde5f41-f9a4-487e-a5ea-4400947a5517@www.fastmail.com>
Daniel Shahaf wrote on Mon, 30 Dec 2019 23:46 +00:00:
> Peter Stephenson wrote on Mon, 30 Dec 2019 22:37 +00:00:
> > On Mon, 2019-12-30 at 18:21 +0000, Daniel Shahaf wrote:
> > > Daniel Shahaf wrote on Mon, Dec 30, 2019 at 18:13:39 +0000:
> > > > Here's a test.
> > >
> > > One more:
> >
> > Thanks; shall I commit my change? It looks like it ought to be local
> > enough we can be reasonably confident it's well tested.
>
> The changes do seem fairly local, and not likely to break anything
> that _doesn't_ use array assignments interactively (get_comp_string())
> or in ${(z)} (bufferwords()), so small risk. I don't have a gut
> feeling for how likely they are to break anything, but if you feel
> they're not going to necessitate a 5.8.1, then sure, go ahead and
> commit to master.
>
> If you aren't sure, then go ahead and commit to the 5.9 branch. :)
I suppose that was too teflony. What I was trying to say is that
I don't know the two functions in question well enough to have a gut
feeling about how destabilizing/risky a particular change is, but in
general, if I had doubts I would err on the side of caution and defer to
the next release.
Cheers,
Daniel
next prev parent reply other threads:[~2019-12-31 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 17:31 Daniel Shahaf
2019-12-24 20:34 ` Phil Pennock
2019-12-24 23:16 ` Sebastian Gniazdowski
2019-12-29 20:55 ` Peter Stephenson
2019-12-29 23:45 ` Peter Stephenson
2019-12-30 18:13 ` Daniel Shahaf
2019-12-30 18:21 ` Daniel Shahaf
2019-12-30 22:37 ` Peter Stephenson
2019-12-30 23:46 ` Daniel Shahaf
2019-12-31 11:58 ` Daniel Shahaf [this message]
2019-12-31 18:35 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c671a8a-d6da-49ca-b3c8-4d9b26e462af@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).