From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id d0fc9808 for ; Tue, 31 Dec 2019 11:59:57 +0000 (UTC) Received: (qmail 20863 invoked by alias); 31 Dec 2019 11:59:49 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: List-Unsubscribe: X-Seq: 24586 Received: (qmail 15862 invoked by uid 1010); 31 Dec 2019 11:59:49 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25677. spamassassin: 3.4.2. Clear:RC:0(66.111.4.26):SA:0(-2.6/5.0):. Processed in 4.593114 secs); 31 Dec 2019 11:59:49 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdefjedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderredtnecuhfhrohhmpedfffgrnhhivghlucfuhhgrhhgrfhdfuceougdrshesuggr nhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenucfrrghrrghmpehmrghilhhfrhhomhepug drshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvnecuvehluhhsthgvrhfuihiivgep td X-ME-Proxy: X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-694-gd5bab98-fmstable-20191218v1 Mime-Version: 1.0 Message-Id: <7c671a8a-d6da-49ca-b3c8-4d9b26e462af@www.fastmail.com> In-Reply-To: <3cde5f41-f9a4-487e-a5ea-4400947a5517@www.fastmail.com> References: <20191223173115.bvhwbpfmqgqhngle@tarpaulin.shahaf.local2> <7b7a941ddc3c20bea6a6b69b1e7ac35d827f320d.camel@ntlworld.com> <373ee4b006198f68c835c902c0bc35242796b33d.camel@ntlworld.com> <20191230181339.hg7ryxivv75ae73r@tarpaulin.shahaf.local2> <20191230182135.abx2lfvbtgsraalh@tarpaulin.shahaf.local2> <8b619ac6e86c3f997781a98d3550304c91f93acc.camel@ntlworld.com> <3cde5f41-f9a4-487e-a5ea-4400947a5517@www.fastmail.com> Date: Tue, 31 Dec 2019 11:58:46 +0000 From: "Daniel Shahaf" To: zsh-users@zsh.org Subject: Re: ${(z)} parsing of multiple array assignments Content-Type: text/plain Daniel Shahaf wrote on Mon, 30 Dec 2019 23:46 +00:00: > Peter Stephenson wrote on Mon, 30 Dec 2019 22:37 +00:00: > > On Mon, 2019-12-30 at 18:21 +0000, Daniel Shahaf wrote: > > > Daniel Shahaf wrote on Mon, Dec 30, 2019 at 18:13:39 +0000: > > > > Here's a test. > > > > > > One more: > > > > Thanks; shall I commit my change? It looks like it ought to be local > > enough we can be reasonably confident it's well tested. > > The changes do seem fairly local, and not likely to break anything > that _doesn't_ use array assignments interactively (get_comp_string()) > or in ${(z)} (bufferwords()), so small risk. I don't have a gut > feeling for how likely they are to break anything, but if you feel > they're not going to necessitate a 5.8.1, then sure, go ahead and > commit to master. > > If you aren't sure, then go ahead and commit to the 5.9 branch. :) I suppose that was too teflony. What I was trying to say is that I don't know the two functions in question well enough to have a gut feeling about how destabilizing/risky a particular change is, but in general, if I had doubts I would err on the side of caution and defer to the next release. Cheers, Daniel