From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id ed0c1f98 for ; Thu, 17 Oct 2019 15:25:11 +0000 (UTC) Received: (qmail 16725 invoked by alias); 17 Oct 2019 15:25:02 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: List-Unsubscribe: X-Seq: 24354 Received: (qmail 27541 invoked by uid 1010); 17 Oct 2019 15:25:02 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25601. spamassassin: 3.4.2. Clear:RC:0(205.235.26.22):SA:0(-1.6/5.0):. Processed in 2.007395 secs); 17 Oct 2019 15:25:02 -0000 X-Envelope-From: SRS0=O4W7=YK=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at bounces.park01.gkg.net designates 205.235.26.22 as permitted sender) X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1571325839; bh=9FNTE/sAUmvEWzySxajwGgyOQoQA0FY5vr3GAkonwIs=; h=From:References:To:Subject:Date:From:Subject; b=k7D4RkhoLnyBLMS9CB6P+hWIN0IN4z4M5/qmjT/i6s8ZEplQKgS+qN0Pzf6fbS37Yk0CjH3e15F+g+wbaDK15W/ZUFf50E/Mf4VZiaYzCMd0efb/x4Vd0K5MiuNbTOmJS7hSHevKvvsYpTc3UjDbxPiFcUtZOH4qBZT2aqHmu5fwq3Z1Sgbx4+9nnhQe+SDupIiGxiEPjbcRTRciEojLJSIHDWxYattRD15qiYqUOKfW6Uj/t4oIMu7gLpCP/RuwaTHNikp5roKxbALiprbZM56rg6m2RFcZmVnUcskwNZTzLw5uDbeYWxiMdMY8mtCE1uV3AF4O3iN3tUmh4Dd3WQ== X-YMail-OSG: 3wlwl6QVM1mtM..c7iBEn8aAopdDEAWdItpK4uQ6Lh4ZZ43KgrwIzz..fL6jp.e JG0Z8ADwZpmnNGFoFwoabshjeZyyhpOtHoAg1Hq4yh5rYRR.l3FBalS4zdG2lBzp9apGYKhq7eh7 Ra9XSrDBtj7CYsAkKcw7z.fHvTMNXTA6c3fD9ApMdD.xD6nFnrTfecuuZjEr7CxF0ncNMp1iI5UO JzoVidFsgkI53cCShSjXtjWIJhVg5RzZhLFFWtCcLFtNh.Cmn7SDgTHN0rmlJjj9B_3Vc7ClCJQM bXVUmog.dQnp9BZr5pKmjFZQAEVz2Pm0BXi6pYwJxjRWwY2wM3M1hHt7MbezwyaOdtnwzx_enDXm dlGQlGV04cngdMXWqxrQAF6_ItUraYCVIs2PkClu5_uST8xeBL5phcdRnPfR.DQxIpvV7JEYwyZT R.6VNBnzOEmUsOSMj9P5plrcR2iVFvRJ9EBDTwM8NOEdGfkNEC3QfPfak_aMX5q_qSMuqDQe3_Py wJ_jKlnYtO8IFnzKDUXFd79_RfUTGlWQHv2aaoTMWsJx_eno81RBJLV8ZWapjpBxkhiMhaX1S9tE 4E_UU45ZtHxCzZspxIE0JAQ9LhWujd83aZSrShJXI9F477xhAB_dDrEL9nh6hLqMB4ip8OWRl2JN QwNz7jt24_6MS6OluwvZk7bEzYhA2.gHdFDuqPnjn4foyuYjIGkksbL8ncWYqtcNiwDSOZNx3CDi V.qwGtt4.RDgqFS2vf9_vAALZ6K2niUiEPGzUUPNqWn297KkoTBnOZfS4gXacNeY0OOX89HPTueB OEbVeZmHHginpZOjk3kcZw3G1Uya1_XAK3aIww284wpzrrRz1ZoLugQzW4gw6D7EbvIbGsS.p70r S.KHIsRNl0D.zqYX1CAdpBSexz7o_N5vd_gmpSrwY9mPZnjg403tfrxhlr27cpiqQ7N0i6n0_9on lF3sjVUptuwXUvGbSOBQd2S0_4OEXH6ortaASpWtJi523dYkwxJWc.Re3L00SennYovRF9jdee6q ujV8jckZ3uKZjWEXcK5ZMsUqXVieAu.tCXbL65suMRMg80ba4lLYcCL.DzIzF6mfkVPXHFzRi2RU pWe1uL0i43v30SA7pwmr_Zh1jJncAKCz6_sAGojGOm9lsaySY0jR1lp2jLr_HXQBTOxM215uQRfE awcjPJD.9Tt2l0uE2rlFXawVbq3HjOSPCyP_XkBXYYyOqGMBNB0DKz5XlEN07eN4nOkvlTX_qZwx zSHOt4oEhWY_7BH0jF87e2VIQU9jkqomiCxWV1B5Ghqucr0bpH0EAYOoDXOVkxoXJx9ndZ4hytWg - In-reply-to: <20191017105155.tshgdwg2m5wwoinm@NUX> From: Oliver Kiddle References: <20191012150611.rwjwhbiqpvwla656@NUX> <11565-1570953731.113937@7Hja.mAXg.cCYH> <20191013110016.pdkjrobevpxkqx6e@NUX> <68873-1571254670.273502@yOop.8xvF.viEb> <20191017105155.tshgdwg2m5wwoinm@NUX> To: zsh-users@zsh.org Subject: Re: ZLE Vi-mode: visual mode selection doesn't match the characters highlighted MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <83593.1571325837.1@hydra> Date: Thu, 17 Oct 2019 17:23:57 +0200 Message-ID: <83594-1571325837.959827@02_A.LZ8k.gRaH> Doron Behar wrote: > I'm glad Oliver that you are attending _this_ issue as well but I'd like > to deal with it at that GitHub thread > (https://github.com/zsh-users/zsh-syntax-highlighting/issues/637), as I > don't feel it's related and focus here on the _cursor's_ character's > highlighting. Pull request #638 there addresses that issue. I was able to reproduce that problem once I tried with a double-quoted (and hence highlighted) string. I had missed that detail before. Would be good if you could give that some testing - I don't use the plugin. Seems ugly that they have to reproduce the builtin highlighting. The region_highlight feature could do with a way to layer entries and to tell which belong to which plugin. > > We could perhaps use some hooks for when visual mode is invoked and > > finished. > > Yea I can use `zle-keymap-select` in the meantime... Except that doesn't trigger for local keymaps like visual. > > Whatever highlighting is chosen, there will be some terminal > > setup for which it is not ideal and somebody who complains. > > I hope I've demonstrated good enough that this is not a terminal > emulator issue, it's an issue of a non blinking cursor. Hence, I think > my complain is legitimate. Yes, I agree that it is legitimate. But I don't see what you'd change in the code other than the default colours. The effect as I understand it is just as I originally described: the cursor reversing the highlighting to give you back the defaults. I think vim's defaults amount to zle_highlight=( region:bg=white,fg=black ) Oliver