From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23096 invoked by alias); 22 Aug 2015 11:48:53 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: X-Seq: 20455 Received: (qmail 10368 invoked from network); 22 Aug 2015 11:48:52 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Biglobe-Sender: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: zsh 5.0.8-test-2 From: "Jun T." In-Reply-To: Date: Sat, 22 Aug 2015 20:48:47 +0900 Content-Transfer-Encoding: 7bit Message-Id: <9306B4F4-68C3-4EC5-93FD-A40346692465@kba.biglobe.ne.jp> References: <20150821215037.6b010cf7@ntlworld.com> To: phy1729@gmail.com, zsh-users@zsh.org X-Mailer: Apple Mail (2.1878.6) X-Biglobe-Spnum: 50090 2015/08/22 09:10, Matthew Martin wrote: > Running on an OpenBSD snapshot, test X02zlevi just hangs without any > output I've tested on my minimal install of OpenBSD 5.6. It seems the test hangs at line 24 of comptest (in function comptestinit()): zpty -r zsh log1 "**" || { Matthews, could you try with the patch at the end of this post? OpenBSD does not have /dev/ptmx (it has /dev/ptm instead), but has posix_openpt() function (OpenBSD 5.3 or later). In zsh-5.0.8, USE_DEV_PTMX is not defined on OpenBSD (because it does not have /dev/ptmx), and zpty.c uses the old BSD-style code (line 246 and below in zpty.c). In zsh-5.0.8-test-2 (or 5.1.0rc), configure.ac has changed and USE_DEV_PTMX is defined because posix_openpt() exists, so zpty.c uses posix_opennt() (HAVE_POSIX_OPENPT is also defined). It is OK if posix_openpt() really works, but the fact that X02zlevi hangs suggests that it is not working as we expect due to some unknown reasons. Simply undefining USE_DEV_PTMX seems to work on my OpenBSD. Jun diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c index 12e42b5..8fc6b21 100644 --- a/Src/Modules/zpty.c +++ b/Src/Modules/zpty.c @@ -154,7 +154,7 @@ getptycmd(char *name) return NULL; } -#ifdef USE_DEV_PTMX +#if defined(USE_DEV_PTMX) && !defined(__OpenBSD__) #ifdef HAVE_SYS_STROPTS_H #include