zsh-users
 help / color / mirror / code / Atom feed
From: "Lawrence Velázquez" <vq@larryv.me>
To: Ray Andrews <rayandrews@eastlink.ca>
Cc: zsh-users@zsh.org
Subject: Re: run time of math problem
Date: Fri, 19 Mar 2021 19:46:16 -0400	[thread overview]
Message-ID: <A78ABFDE-07C4-40E5-A9CD-6DC3B2C45867@larryv.me> (raw)
In-Reply-To: <a1c6d13a-7a04-fba4-4419-7eccbf013824@eastlink.ca>

> On Mar 19, 2021, at 7:18 PM, Ray Andrews <rayandrews@eastlink.ca> wrote:
> 
> ... I'd expect the thing to run a teeny bit faster but in fact it
> runs about 15% slower.  Is that explicable?  Does zsh prefer
> calculations done in steps with variables for each step?  Or is this
> just some little anomaly?  Things might not optimize every time.

Think about how your change affects your algorithm.

>   for ((level=1; level<100; level++)); do
>        sum=
>        remainder=$(( (level - 1.0) / level ))
>        for ((terms=level; terms; terms--)); do
>            sum+=$(( remainder**(terms - 1) ))
>        done
>        divided=$(( sum * (1.0 / level) ))
>        echo for level: $level, survival: $divided
>   done

Here, you evaluate "(level - 1.0) / level" 99 times.

> Now if I avoid the 'remainder' variable:
> 
>     for ((level=1; level<100; level++)); do
>         sum=
>         for ((terms=level; terms; terms--)); do
> 
>            # 'remainder' calculation done directly here:
>            sum+=$(( ( (level - 1.0) / level )**(terms - 1) ))
>        done
>        divided=$(( sum * (1.0 / level) ))
>        echo for level: $level, survival: $divided
>   done

Here, you evaluate it 4950 times.

vq


  reply	other threads:[~2021-03-19 23:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 23:18 Ray Andrews
2021-03-19 23:46 ` Lawrence Velázquez [this message]
2021-03-19 23:51   ` Ray Andrews
2021-03-19 23:52 ` Oliver Kiddle
2021-03-20  2:40   ` Ray Andrews
2021-03-20  3:59     ` Lawrence Velázquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A78ABFDE-07C4-40E5-A9CD-6DC3B2C45867@larryv.me \
    --to=vq@larryv.me \
    --cc=rayandrews@eastlink.ca \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).