zsh-users
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh-users@zsh.org
Subject: Re: Please fix history-search-backward/forward
Date: Sun, 29 Aug 2010 03:52:36 +0300	[thread overview]
Message-ID: <AANLkTik+ACKiD+n5g-MUUxjiAdzbd67_CH7P3E8cpkZ1@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinysNBjLTO7DoPMtdPvub=UC=y0Za_7xTKYZRYp@mail.gmail.com>

On Sun, Aug 29, 2010 at 1:33 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
> On 29 August 2010 00:23, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> On Sat, Aug 28, 2010 at 11:55 PM, Mikael Magnusson <mikachu@gmail.com> wrote:
>>> On 28 August 2010 20:54, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>>>> zle says:
>>>> Search backward in the history for a line beginning with the first
>>>> word in the buffer.
>>>>
>>>> GNU readline says:
>>>> Search backward through the history for the string of characters
>>>> between the start of the current line and the point.
>>
>>>> [1] http://zsh.sourceforge.net/Doc/Release/User-Contributions.html
>>>
>>> I think you want history-beginning-search-backward/forward ? Changing
>>> the effects of a widget is (and I think I can say this quite safely)
>>> is not really an option.
>>
>> I already mentioned history-beginning-search-backward/forward
>> (history-search-end), the point is not how to do that.
>
> history-beginning-search-backward and
> history-beginning-search-backward-end are not the same. The one I
> mentioned is builtin and doesn't need any autoloads.

Ah!

But this is misleading:

---
history-beginning-search-backward
Search backward in the history for a line beginning with the current
line up to the cursor.

history-search-backward
Search backward in the history for a line beginning with the first
word in the buffer.
---

So both start from the beginning, so what's the 'beginning' in the
former supposed to differentiate? Wouldn't history-cur-search-backward
make more sense? Or even better:

---
history-search-backward
Search backward in the history for a line beginning with the current
line up to the cursor.

history-word-search-backward
Search backward in the history for a line beginning with the first
word in the buffer.
---

Note: I'm only objecting to the misleading names.

-- 
Felipe Contreras


  reply	other threads:[~2010-08-29  0:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-28 18:54 Felipe Contreras
2010-08-28 20:55 ` Mikael Magnusson
2010-08-28 22:23   ` Felipe Contreras
2010-08-28 22:33     ` Mikael Magnusson
2010-08-29  0:52       ` Felipe Contreras [this message]
2010-08-30 17:34         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTik+ACKiD+n5g-MUUxjiAdzbd67_CH7P3E8cpkZ1@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=mikachu@gmail.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).