From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 804 invoked by alias); 15 Aug 2017 10:53:57 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: X-Seq: 22829 Received: (qmail 4789 invoked by uid 1010); 15 Aug 2017 10:53:57 -0000 X-Qmail-Scanner-Diagnostics: from mail-yw0-f175.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.161.175):SA:0(-1.4/5.0):. Processed in 2.965194 secs); 15 Aug 2017 10:53:57 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: julien.nicoulaud@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Nm64LJBJ27i6b+GpTc9kvf5ZFnwTUrwEcUo5WIR/I2s=; b=OyzNLUQzO3XphEY3oaEi7WJzrB02zTv5uzPDFJJ2DJVolI2aW0JuQyQJxZdgYpeEhk vtz9GD7HHo1vSAKtEZvBWK+kBcEElINCx2LZ9sFJl/cvpP5RUkKbImzgDnqsgJonmkHX GJT2sCGpNrBD1q18nqGIq4zvA85sc07Aowx/4ZrfXB3pLJ/yzZsqMnDvEPoOAbbJH00y z+SwuTLfhGkancRiHx3mxWcjian3lW+AQDRRCLG+6XaaOH1kZcmq46B82qhNHm0kdgnI kRu+YIHdf3u8XTjRbjmI0T1YI/i6UMGevd4dHl6//VfAvDaqUzbr4y4Fr4XefXljhjqT vj/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Nm64LJBJ27i6b+GpTc9kvf5ZFnwTUrwEcUo5WIR/I2s=; b=m6hAuR6GqJy1An82nsv6HAQQhhPJufODwlOoA4wkG1Tn0kOuAFMX0Mg7H82iEA2C/y jMckbSxfgCF4H2i00x60gR9apVqv44ebtnfToUW3YvVVnguhF8VeAjEydvrPsKzuYYvN X1uxdfjh/t25ILizkRVFKfQsoZgsDNhaB8YjsILRN2TQ5B4Xu7WdMNWtuuEnsCgnYfXI DyPiPnwNE92LD24YGBP4JI5vnzbxvtTQIOyz8IVukIbDPgnbB733i0pEknOwv/hIMKbn AhXfUYdpDWEbr0HmxMzgUNVDgRBpbHir2OtB1+bRJGYXaq26yEWseeY5HRTO8cRxTxq3 S7sA== X-Gm-Message-State: AHYfb5jsToXZHiN9fb2lMRh10H+qUPRmgImOUUQn1elg2CRgQBhBRXIg 6m6f/+2Gpdgboa79pz6hTDYwni0JHT0A X-Received: by 10.129.78.137 with SMTP id c131mr22037215ywb.464.1502794430235; Tue, 15 Aug 2017 03:53:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <191781502787229@web22g.yandex.ru> References: <368651502750468@web46j.yandex.ru> <191781502787229@web22g.yandex.ru> From: Julien Nicoulaud Date: Tue, 15 Aug 2017 12:53:09 +0200 Message-ID: Subject: Re: Zsh docker images To: "Nikolay Aleksandrovich Pavlov (ZyX)" Cc: Mailing-list zsh-users Content-Type: multipart/alternative; boundary="001a114dc0ee2f4aeb0556c89862" --001a114dc0ee2f4aeb0556c89862 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for the tips. The solution you describe requires way more setup and maintainance than what we have currently, so I prefer to keep things simple. zsh-syntax-highlighting is a low activity project, we just need to make sure tests run in acceptable time, and there is not too much adherence to Travis-CI. 2017-08-15 10:53 GMT+02:00 Nikolay Aleksandrovich Pavlov (ZyX) < kp-pav@yandex.ru>: > > > 15.08.2017, 02:19, "Julien Nicoulaud" : > > 2017-08-15 0:41 GMT+02:00 Nikolay Aleksandrovich Pavlov (ZyX) < > > kp-pav@yandex.ru>: > > > >> 15.08.2017, 01:12, "Julien Nicoulaud" : > >> > Hi all, > >> > > >> > I just wanted to advertise a small project that could be useful to > other > >> > zsh users: https://github.com/zsh-users/zsh-docker > >> > > >> > This builds images of many versions of zsh (including a daily build > of > >> > zsh's master branch) and deploys them to Docker Hub ( > >> > https://hub.docker.com/u/zshusers). > >> > > >> > So you can do, for instance: > >> > > >> > $ docker run -it zshusers/zsh-5.3.1 > >> > > >> > -> will launch an interactive session of zsh 5.3.1 > >> > > >> > We use it to automatically test zsh-syntax-highlighting on all > supported > >> > versions of zsh. > >> > >> What you could just as well do without docker which would make travis > run > >> faster due to not needed `sudo: required` and ability to setup travis > >> cache. For testing something locally your docker images make more sen= se > >> because they are easier to use then compiling that big amount of zsh > >> versions. > > > > You mean, instead of using Docker, building the right zsh version on ea= ch > > job and use Travis cache ? I am not sure that would work as we would ha= ve > > to "make install" zsh anyway, so we would need sudo... > > 1. No, you may just build it with a bot and save an archive. > https://github.com/powerline/bot-ci works like this for years, though I > only have one zsh version. Binaries are in https://github.com/powerline/ > deps. > 2. You need absolutely no `sudo` for `make install`. Just do user-local > installation, something like ~/.local-zsh-$ZSH_VERSION. The *build bot* I > referenced above is using container-based builds without sudo, not to > mention powerline itself which it builds dependencies for. Works fine for > CPython (some variant not provided by travis), zsh, zpython, tmux, fish, = rc > shell, libvterm, Vim, various Vim plugins and Python packages. This is on= ly > a matter of what you pass as a prefix. > 3. Actually it is possible to build in the job itself and use travis > cache, Neovim works this way. I found it more complicated to setup and it > would make build times unpredictable for powerline since I do not hardcod= e > versions like Neovim does. > > > > > The Docker setup makes things very simple on zsh-syntax-highlighting > side, > > it's only one line (https://github.com/zsh-users/ > > zsh-syntax-highlighting/blob/master/.travis.yml#L30), so it stays clean > and > > it's easy to use on other projects as well. > > > >> Also why you have no builds for PRs > > > > All those PRs were submitted before we setup Travis-CI, I'm not sure if > we > > can trigger builds, maybe if contributors rebase their branches ? > > > >> and why you don=E2=80=99t merge those 24 jobs into something like 7 (= 4.3*, > 5.0*, > >> 5.1*, 5.2*, 5.3*, 5.4*, master)? Less then twenty seconds to run test= s > in a > >> single job, lots of time to initialize VMs and there is nothing which > may > >> prevent you from consequently running two docker commands in one job, > or > >> using two zsh versions via other means. > > > > Yeah sure, it was just easier to setup and to get a dashboard with ever= y > > version. We want to make it easy for contributors what their pull reque= st > > broke. If we start grouping jobs, log files will be harder to analyse. > > > > Currently build time is 5/6 minutes, so I don't see it as a big issue. > > Travis has folds, so you may create a fold for each version and print a > summary of =E2=80=9Cwhat failed=E2=80=9D below for contributors to know w= hat to unfold. (Of > course, this works in web interface only.) See https://github.com/ZyX-I/ > neovim/blob/663ca27d3ac9567bb82fc66141aae67bd80190d2/ci/common/suite.sh > for an example, though I must say I have not set up `set [+-]x` well, so > some trace lines appear outside folds. > > > > >> > > >> > Cheers, > >> > Julien > --001a114dc0ee2f4aeb0556c89862--