From: "Jesper Nygårds" <jesper.nygards@gmail.com>
To: Zsh Users <zsh-users@zsh.org>
Subject: Re: Extended globbing seems to have become much slower in recent versions of Zsh
Date: Tue, 1 Mar 2016 20:11:09 +0100 [thread overview]
Message-ID: <CABZhJg-ynr8eERC+q-yVYk5sfZK-6yqdLcoTrerA8d6cERkyEQ@mail.gmail.com> (raw)
In-Reply-To: <160301102807.ZM8036@torch.brasslantern.com>
[-- Attachment #1: Type: text/plain, Size: 2585 bytes --]
New runs with your suggestion:
% /usr/local/bin/zsh --version
zsh 5.2 (x86_64-apple-darwin14.5.0)
% /usr/local/bin/zsh -f
% setopt EXTENDED_GLOB; float SECONDS MYNOW
% MYNOW=$SECONDS; :
**/*~(|*/)(build|target|node|node_modules|.idea|*.min.js|*.iml|TAGS)(|/*)(-.D);
print $(( $SECONDS - $MYNOW ))
36.463269999999994
% MYNOW=$SECONDS; :
(#i)**/*~(|*/)(build|target|node|node_modules|.idea|*.min.js|*.iml|TAGS)(|/*)(-.D);
print $(( $SECONDS - $MYNOW ))
45.178413000000006
% MYNOW=$SECONDS; :
**/*~(|*/)(build|target|node|node_modules|.idea|*.min.js|*.iml|TAGS)(|/*);
print $(( $SECONDS - $MYNOW ))
26.012812999999994
% MYNOW=$SECONDS; :
(#i)**/*~(|*/)(build|target|node|node_modules|.idea|*.min.js|*.iml|TAGS)(|/*);
print $(( $SECONDS - $MYNOW ))
23.646717999999964
-------------------------------------------------------
% /bin/zsh --version
zsh 5.0.5 (x86_64-apple-darwin14.0)
% /bin/zsh -f
% setopt EXTENDED_GLOB; float SECONDS MYNOW
% MYNOW=$SECONDS; :
**/*~(|*/)(build|target|node|node_modules|.idea|*.min.js|*.iml|TAGS)(|/*)(-.D);
print $(( $SECONDS - $MYNOW ))
13.899865999999989
% MYNOW=$SECONDS; :
(#i)**/*~(|*/)(build|target|node|node_modules|.idea|*.min.js|*.iml|TAGS)(|/*)(-.D);
print $(( $SECONDS - $MYNOW ))
10.239834999999999
% MYNOW=$SECONDS; :
**/*~(|*/)(build|target|node|node_modules|.idea|*.min.js|*.iml|TAGS)(|/*);
print $(( $SECONDS - $MYNOW ))
5.4469640000000084
% MYNOW=$SECONDS; :
(#i)**/*~(|*/)(build|target|node|node_modules|.idea|*.min.js|*.iml|TAGS)(|/*);
print $(( $SECONDS - $MYNOW ))
6.2737860000000296
On Tue, Mar 1, 2016 at 7:28 PM, Bart Schaefer <schaefer@brasslantern.com>
wrote:
> On Mar 1, 12:39pm, Jesper Nygards wrote:
> }
> } Here's another run with your supplied patterns. I hope I didn't
> } misunderstand how you wanted me to use the SECONDS variable.
>
> Close enough.
>
> } In any case, as you can see below, the globbing more or less takes the
> same
> } time for the simple patterns, but as soon as I introduce the exclusions,
> } the 5.2 version is around six times slower than the 5.0.5 version.
>
> That tends to point to changes in pattern matching rather than globbing
> (related but distinct operations), but can you also try it with
>
> : pattern-goes-here
>
> instead of
>
> myfiles=( pattern-goes-here )
>
> ?? I'd like to factor out the contributions of memory management for the
> array assignment. I ran a couple of quick local tests and with assignment
> there are about 50% more calls to malloc in the current git head than in
> 5.0.5, but without assignment there are slightly fewer in current.
>
next prev parent reply other threads:[~2016-03-01 19:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 20:18 Jesper Nygårds
2016-02-29 19:12 ` Bart Schaefer
2016-03-01 11:39 ` Jesper Nygårds
2016-03-01 18:28 ` Bart Schaefer
2016-03-01 19:11 ` Jesper Nygårds [this message]
2016-03-02 0:03 ` Bart Schaefer
2016-03-02 8:39 ` Jesper Nygårds
2016-03-03 0:06 ` Bart Schaefer
2016-03-04 8:17 ` Jesper Nygårds
2016-03-04 13:22 ` Jesper Nygårds
2016-03-04 14:03 ` Peter Stephenson
2016-03-04 14:20 ` Peter Stephenson
2016-03-04 21:49 ` Peter Stephenson
2016-03-05 17:47 ` Bart Schaefer
2016-03-06 18:10 ` Peter Stephenson
2016-03-07 9:59 ` Jesper Nygårds
2016-03-07 10:15 ` Peter Stephenson
2016-03-05 17:37 ` Bart Schaefer
2016-03-06 17:31 ` Bart Schaefer
2016-03-21 23:05 ` Bart Schaefer
2016-03-02 9:32 ` Peter Stephenson
2016-03-02 23:46 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABZhJg-ynr8eERC+q-yVYk5sfZK-6yqdLcoTrerA8d6cERkyEQ@mail.gmail.com \
--to=jesper.nygards@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).