From: Seth House <seth@eseth.com>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: Ioannis Koutras <ioannis.koutras@gmail.com>, zsh-users@zsh.org
Subject: Re: vcs_info on a hg repository with a git subrepository; actionformats works ok, formats does not
Date: Mon, 17 Sep 2012 12:53:29 -0700 [thread overview]
Message-ID: <CABsXarGXg_m1i4tjPbUS5Fz+_BOGqbKKoG5-wKF01rOKgsKvhA@mail.gmail.com> (raw)
In-Reply-To: <CABsXarF5CM=CjhrrCsPBdY0es2SpY=dQC2116grsq4rYDPsE=g@mail.gmail.com>
On Mon, Sep 17, 2012 at 9:57 AM, Seth House <seth@eseth.com> wrote:
> That said, their addition of git commands to the debug output isn't
> outputting terribly useful info. I wonder if that is intentional.
It is, indeed, intentional:
http://selenic.com/hg/diff/58a6f3f4d553/mercurial/subrepo.py
> The --debug flag is used to get hg to output the full sha.
Relying on --debug here is not ideal. Something like this was bound to
happen eventually. Unfortunately, I don't believe there's a way to
retrieve all info of interest to VCS_Info with a single call to
Mercurial. (Invoking the Python interpreter is too slow to do more
than once while drawing the shell prompt.) I have done quite a bit of
experimenting, searching, and asking on this.
I propose one of the following:
1) Alter the hg backend to work without the full 40-char hash.
The ``hg id`` command will always return a unique hash. The only thing
the full hash is being used for in the hg backend is comparisons with
MQ patches and that can be changed to be a left-match instead. We can
document why the full hash isn't available and if users are expecting
40-chars we can give an example of how to pad the value with spaces.
This changes existing behavior.
2) Continue using --debug and add a workaround for this issue.
It's plausible that the output of interest will always appear at the
bottom of the debug output. Mercurial does have a
backward-compatibility policy for its output formats but this does not
extend to debug output (obviously).
FWIW, my personal preference is the first option as I feel the 40-char
hash is rarely desired or useful in a shell prompt.
Thoughts?
next prev parent reply other threads:[~2012-09-17 19:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 13:37 Ioannis Koutras
2012-09-17 14:50 ` Frank Terbeck
2012-09-17 15:02 ` Ioannis Koutras
2012-09-17 15:15 ` Frank Terbeck
2012-09-17 15:38 ` Ioannis Koutras
2012-09-17 16:01 ` Frank Terbeck
2012-09-17 16:06 ` Seth House
2012-09-17 16:33 ` Frank Terbeck
2012-09-17 16:57 ` Seth House
2012-09-17 19:53 ` Seth House [this message]
2012-09-17 20:23 ` Seth House
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABsXarGXg_m1i4tjPbUS5Fz+_BOGqbKKoG5-wKF01rOKgsKvhA@mail.gmail.com \
--to=seth@eseth.com \
--cc=ft@bewatermyfriend.org \
--cc=ioannis.koutras@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).