zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh Users <zsh-users@zsh.org>
Cc: Eric Cook <llua@gmx.com>, Dan Arad <dan1994@gmail.com>
Subject: Re: Duplicate results in _python - (Re: [MINOR BUG] Duplicate results in tab-menu)
Date: Sat, 16 Jul 2022 20:48:51 -0700	[thread overview]
Message-ID: <CAH+w=7Z6_9fHjsOnapcx_njk3J9TE-7WGu2yCVWOe4q1FViefg@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7YMMDPTTBiVshGuG0_2fO0hU5Twf23Qcw-eRg_FJrFrcg@mail.gmail.com>

On Thu, Jun 23, 2022 at 10:41 PM Bart Schaefer
<schaefer@brasslantern.com> wrote:
>
> The trouble here is that the completion invoked by _dispatch is
> explicitly allowed to change _compskip to control the behavior of
> _dispatch.  It just happens that any completion that relies on calling
> _normal may do so incorrectly.
>
> [...]  So the fix appears to be to make _compskip local to
> _python, which seems a bit icky because it doesn't help with any other
> completions that may have it wrong.  Better suggestions?

As there's been no follow-up, and this also appears to address issues
raised in https://zsh.org/workers/45767, I'm going to go ahead and
commit the change to _python.


  reply	other threads:[~2022-07-17  3:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23  9:54 [MINOR BUG] Duplicate results in tab-menu Morten Nissov
2022-06-23 14:42 ` Duplicate results in _python - (Re: [MINOR BUG] Duplicate results in tab-menu) Eric Cook
2022-06-24  5:41   ` Bart Schaefer
2022-07-17  3:48     ` Bart Schaefer [this message]
2022-06-24 14:40   ` Morten Nissov
2022-06-26  5:15     ` Bart Schaefer
2022-06-26  5:18       ` Bart Schaefer
2022-06-27  8:00         ` Morten Nissov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7Z6_9fHjsOnapcx_njk3J9TE-7WGu2yCVWOe4q1FViefg@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=dan1994@gmail.com \
    --cc=llua@gmx.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).