From: Bart Schaefer <schaefer@brasslantern.com>
To: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: Feature request: a new warning option
Date: Wed, 9 Oct 2019 11:15:39 -0700 [thread overview]
Message-ID: <CAH+w=7bADq2FOjfrqBLN1tg_kbsDmQNt24riVHnZan24QCTyDg@mail.gmail.com> (raw)
In-Reply-To: <CAKc7PVDN-GspoiS-iVR5ThdbDVbLWVNJWcZ=TyY0=9ydtPswAw@mail.gmail.com>
On Tue, Oct 8, 2019 at 9:03 PM Sebastian Gniazdowski
<sgniazdowski@gmail.com> wrote:
>
> The warning would be triggered when:
> - a an || would occur after an instruction preceded by &&,
> - the instruction wouldn't be an always-true instruction
To add to what's already been bandied about:
This seems like something better suited for a shell script "lint" type
program, rather than something to emit as a run-time warning from the
shell itself. There's also the question of when this warning would be
emitted; if at execute time, is it really doing anything useful? If
at parse time, the parser has to become aware of even more semantics.
Creation of global variables and references to unset variables can't
really be detected by syntax examination, but all the cases the shell
could successfully warn about in this scheme are, I think, resolvable
by looking at the individual pipelines. If you want a runtime
warning, maybe do something with ${(z)ZSH_DEBUG_CMD} in a TRAPDEBUG
function?
next prev parent reply other threads:[~2019-10-09 18:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 4:02 Sebastian Gniazdowski
2019-10-09 8:45 ` Roman Perepelitsa
2019-10-09 8:49 ` Peter Stephenson
2019-10-09 11:56 ` Sebastian Gniazdowski
2019-10-09 12:08 ` Roman Perepelitsa
2019-10-09 13:17 ` Sebastian Gniazdowski
2019-10-09 13:24 ` Peter Stephenson
2019-10-09 13:41 ` Sebastian Gniazdowski
2019-10-09 14:07 ` Ray Andrews
2019-10-09 15:19 ` Peter Stephenson
[not found] ` <CAKc7PVBQnt_ZE3X=8gz5R_VURwaTL3mDL=X-7H__yYqAjvXoWA__41912.055101578$1570628583$gmane$org@mail.gmail.com>
2019-10-09 14:04 ` Stephane Chazelas
2019-10-09 13:40 ` Roman Perepelitsa
2019-10-09 17:36 ` Daniel Shahaf
2019-10-09 18:15 ` Bart Schaefer [this message]
2019-10-10 3:29 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bADq2FOjfrqBLN1tg_kbsDmQNt24riVHnZan24QCTyDg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=sgniazdowski@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).