zsh-users
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Marc Chantreux <eiro@phear.org>
Cc: zzapper <zsh@rayninfo.co.uk>, Zsh Users <zsh-users@zsh.org>
Subject: Re: (prefix case terminators?) Re: alias with a parameter
Date: Thu, 15 Apr 2021 16:52:38 -0700	[thread overview]
Message-ID: <CAH+w=7bFEnvAYAkP6=rUdUoZzcySBHN7iinPWc9OJ7seOsciHw@mail.gmail.com> (raw)
In-Reply-To: <YHiaXK7OiNZS7zIJ@prometheus.u-strasbg.fr>

On Thu, Apr 15, 2021 at 12:56 PM Marc Chantreux <eiro@phear.org> wrote:
>
> > However you really don't need that test at all:
> > case "$1" in
> >   ("") false;;
> >   ([A-Z]|V<->|G*);;
> >   (*) echo "Yes expand";;
> > esac
>
> i would have written ${1-} so -u can be used.

I'm not following that at all:  -u where?

> also: i really think that using terminators as "continuation"
> ease the code reading

Entirely my opinion, but I find your example much MORE difficult to read.

> * it makes code more aligned

Only if you start with the (jarring to me) "in" on a new line.

> * it's easier to spot a different terminator than ;;

For that, I'd put the terminator on a line by itself, which I would
also do if the case branch was more than one line or if the case
pattern was quite long, but with short patterns and the terminators
all ;; it seems unnecessary.


  reply	other threads:[~2021-04-15 23:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 22:55 dukeofpurl
2021-04-06  0:16 ` lb
2021-04-06  3:40   ` Duke Normandin
2021-04-06 14:42     ` Greg Klanderman
2021-04-06  2:47 ` Grant Taylor
2021-04-07  7:05   ` Stephane Chazelas
2021-04-07 12:48     ` lb
2021-04-07 12:58       ` Peter Stephenson
2021-04-08  1:06       ` Grant Taylor
2021-04-08  1:25         ` Daniel Shahaf
2021-04-09  2:55           ` Grant Taylor
2021-04-09 22:49             ` Daniel Shahaf
2021-04-10  7:32               ` david rayner
2021-04-10 10:38                 ` Marc Chantreux
2021-04-14 11:10                   ` zzapper
2021-04-15 18:19                     ` Bart Schaefer
2021-04-15 19:56                       ` (prefix case terminators?) " Marc Chantreux
2021-04-15 23:52                         ` Bart Schaefer [this message]
2021-04-16  6:46                           ` Marc Chantreux
2021-04-15 20:30                       ` Daniel Shahaf
2021-04-16  7:34                         ` zapper
2021-04-16 10:12                         ` Stephane Chazelas
2021-04-10 16:30               ` Grant Taylor
2021-04-10 16:34                 ` Grant Taylor
2021-04-13 11:22                 ` Daniel Shahaf
2021-04-07 14:43     ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7bFEnvAYAkP6=rUdUoZzcySBHN7iinPWc9OJ7seOsciHw@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=eiro@phear.org \
    --cc=zsh-users@zsh.org \
    --cc=zsh@rayninfo.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).