From: Bart Schaefer <schaefer@brasslantern.com>
To: Jordan Klassen <jordan@klassen.me.uk>
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: git-subtree completions
Date: Fri, 13 May 2016 02:39:52 -0700 [thread overview]
Message-ID: <CAH+w=7bGo6KiooeDHAFor2ZrKw9a24=RXBBpP=vdsMG8VUuJ+A@mail.gmail.com> (raw)
In-Reply-To: <CAEsdBDkYMG6fopG9uAxXPZuDoOu5iW1QBBwM1r1-BCZ-iEtEpw@mail.gmail.com>
On Wed, May 11, 2016 at 10:57 PM, Jordan Klassen <jordan@klassen.me.uk> wrote:
>
> I need feedback on it, and if it's better to submit a patch via `git
> send-email` let me know.
Generally speaking, yes, you should send a patch to zsh-workers.
> In particular, is there an easy way to test this
> without actually compiling zsh?
Since the diff is to a script file, yes. You just need to change the
$fpath array to list the directory containing your edited file ahead
of the directory containing the un-edited copy, before the first time
you attempt to complete after "git".
> How do I fix my `THIS_IS_A_HACK` issue?
I'm not sure what that's meant to accomplish? As far as I can tell
using a pattern that won't match anything should be the same as
leaving out the -A entirely.
> And code review in general.
There are others better qualified than me to critique changes to the
git completion ...
next prev parent reply other threads:[~2016-05-13 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 5:57 Jordan Klassen
2016-05-13 9:39 ` Bart Schaefer [this message]
2016-05-13 12:02 ` Oliver Kiddle
[not found] ` <27621.1463140958__28965.9567446963$1463141465$gmane$org@thecus.kiddle.eu>
2016-07-07 2:00 ` Daniel Shahaf
2016-07-13 4:24 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7bGo6KiooeDHAFor2ZrKw9a24=RXBBpP=vdsMG8VUuJ+A@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=jordan@klassen.me.uk \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).