From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-users-return-21557-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 5991 invoked by alias); 13 May 2016 09:39:57 -0000
Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Users List <zsh-users.zsh.org>
List-Post: <mailto:zsh-users@zsh.org>
List-Help: <mailto:zsh-users-help@zsh.org>
X-Seq: 21557
Received: (qmail 17127 invoked from network); 13 May 2016 09:39:56 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc;
        bh=gq3Sb5c7fpYZ6ts+FDFEqJJWJenp+srg7KK3RLDwFFc=;
        b=vFhOjOyLlwJk20GJkeTZrVncI4/Qo8qRIBQGpNr/G3PG7gqhSlkRhsCA85oOrT267z
         e6q433Q73x6Z3WiTUUqQYwZTOxVpWdWqmeemh63BvcjNkRiPpPge4pRYF81qvHGD5ARn
         ebdZB8cn3N69YRgr/H+ZsEhEvwCM3GpzenaCMdp7QVeZOynsmEkq1abfMTofG8B7yjzM
         5nAiD7SRbT6c9pEi7PkyucBjVlkfDrRUndLd8mPNHnXIVpUe+kOlcKNK4EnFKz2nojO0
         CfJGYC4OSEiGg8LuaHqFqMV46Pc0gxBfaUJWLdUuZ6pJJid4OX3SgvWDkMJH70XQAvzb
         qMRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:cc;
        bh=gq3Sb5c7fpYZ6ts+FDFEqJJWJenp+srg7KK3RLDwFFc=;
        b=nLnvI/wDAM0z8P5Fc8aiCPyhkCjiq9Cj+XCDqP6+EU7rw5gjSd8Us4Z84d+wuKX+Uz
         XVHBjebLzsHFU7Yc3PqOV+n4mHi1T0sxc0l2BCMmh7p/msPrDiPyFToyRzfDCySmcpsr
         3b4ghmldUVS9jTlibmrrOyYpjYmq9dS+Q1iAtmIHkAF5puaoT+li6krEGpJ57HPQH5XK
         kSDuJm3S+O9Dv7hcVXwIUVhVQce0q2c/tE5glW6RfTBbF4ZrP+msOfqfrlL0hINm2z4t
         ulc4qCcBUaiZuBWDusNwY1n2iZ2m9kD7HoJ7LUwIwqnGpvaDOad2R3wJmAeFL+csRTJj
         BdEw==
X-Gm-Message-State: AOPr4FUjZT+Rwn1o/7bn1gAa6w1WyNMwUYl6lcfnaSPsRyM8QF1tUTpazjvKq5hXnXuiziJ/BAC7eDfyTZcr0g==
MIME-Version: 1.0
X-Received: by 10.112.198.72 with SMTP id ja8mr6290287lbc.112.1463132392494;
 Fri, 13 May 2016 02:39:52 -0700 (PDT)
In-Reply-To: <CAEsdBDkYMG6fopG9uAxXPZuDoOu5iW1QBBwM1r1-BCZ-iEtEpw@mail.gmail.com>
References: <CAEsdBDkYMG6fopG9uAxXPZuDoOu5iW1QBBwM1r1-BCZ-iEtEpw@mail.gmail.com>
Date: Fri, 13 May 2016 02:39:52 -0700
Message-ID: <CAH+w=7bGo6KiooeDHAFor2ZrKw9a24=RXBBpP=vdsMG8VUuJ+A@mail.gmail.com>
Subject: Re: git-subtree completions
From: Bart Schaefer <schaefer@brasslantern.com>
To: Jordan Klassen <jordan@klassen.me.uk>
Cc: Zsh Users <zsh-users@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Wed, May 11, 2016 at 10:57 PM, Jordan Klassen <jordan@klassen.me.uk> wrote:
>
> I need feedback on it, and if it's better to submit a patch via `git
> send-email` let me know.

Generally speaking, yes, you should send a patch to zsh-workers.

> In particular, is there an easy way to test this
> without actually compiling zsh?

Since the diff is to a script file, yes.  You just need to change the
$fpath array to list the directory containing your edited file ahead
of the directory containing the un-edited copy, before the first time
you attempt to complete after "git".

> How do I fix my `THIS_IS_A_HACK` issue?

I'm not sure what that's meant to accomplish?  As far as I can tell
using a pattern that won't match anything should be the same as
leaving out the -A entirely.

> And code review in general.

There are others better qualified than me to critique changes to the
git completion ...