From: "Paulo César Pereira de Andrade" <paulo.cesar.pereira.de.andrade@gmail.com>
To: zsh-users@zsh.org
Subject: zsh heredoc crash
Date: Fri, 9 Sep 2016 10:00:54 -0300 [thread overview]
Message-ID: <CAHAq8pEm1FHNvoUJUq2t86P-QKtMdT3uScDUGn-dCscJUGvWew@mail.gmail.com> (raw)
Hi,
zsh (tested on 5.0.2) can be made to crash with a pattern
like this:
---8<---
#!/usr/bin/zsh
cat >> /tmp/try <<EOF
export A="$(tr '\n' ' ' <<BLDARC
content
BLDARC)"
EOF
---8<---
It will also crash with a simpler (but wrong) version:
---8<---
cat >> /tmp/try <<EOF
foo
EOF)
---8<---
With this patch:
---8<---
diff -up zsh-5.0.2/Src/exec.c.orig zsh-5.0.2/Src/exec.c
--- zsh-5.0.2/Src/exec.c.orig 2016-09-06 15:10:19.394565181 -0300
+++ zsh-5.0.2/Src/exec.c 2016-09-06 15:10:36.300551444 -0300
@@ -3631,16 +3631,16 @@ gethere(char **strp, int typ)
*bptr++ = '\n';
}
*t = '\0';
+ s = dupstring(buf);
+ zfree(buf, bsiz);
if (!qt) {
int ef = errflag;
- parsestr(buf);
+ parsestr(s);
if (!errflag)
errflag = ef;
}
- s = dupstring(buf);
- zfree(buf, bsiz);
return s;
}
---8<---
it will just print something like:
/tmp/a.sh:8: parse error
The problem is that the buf vector is allocated with
zalloc, and when calling parsestr it will call hrealloc
on the zalloc'ed buffer.
The patch just works around the crash, but a better
error message may be shown for this pattern. Ksh
allows it silently, and bash prints a warning but also
allow it.
The workaround in the script would be to not add
anything after the heredoc delimiter.
Thanks,
Paulo
next reply other threads:[~2016-09-09 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 13:00 Paulo César Pereira de Andrade [this message]
2016-09-09 14:33 ` Kamil Dudka
2016-09-09 16:35 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHAq8pEm1FHNvoUJUq2t86P-QKtMdT3uScDUGn-dCscJUGvWew@mail.gmail.com \
--to=paulo.cesar.pereira.de.andrade@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).