From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: umount completion context and tags
Date: Sun, 14 Dec 2014 19:51:15 +0100 [thread overview]
Message-ID: <CAHYJk3QWZNzy6BeFuaYfzCPdF-vUCxfuJ=L1njGXF0Kg7NjCxA@mail.gmail.com> (raw)
In-Reply-To: <141214094722.ZM23704@torch.brasslantern.com>
On Sun, Dec 14, 2014 at 6:47 PM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> On Dec 14, 6:13pm, Mikael Magnusson wrote:
> }
> } I see now that the gentoo /etc/filesystems has some lines in it with
> } comments, and the completer doesn't remove them. How about instead of
> } this,
> }
> } fss+=( ${$(</etc/filesystems)#\*} )
> }
> } we use this?
> }
> } fss+=( ${${${(f)"$(</etc/filesystems)"}:#\#*}#\*} )
>
> Seems reasonable to me.
I've commited this, and I'll leave the rest to someone who knows more
about things, I think.
> } > usbfs /proc/bus/usb usbfs rw 0 0
> } >
> } > so _mount assigns
> } >
> } > dev_tmp=( /dev/hda2 usbfs /dev/hda1 sunrpc )
> } >
> } > which subsquently interprets everything that doesn't start with a slash
> } > as a device label.
> }
> } I'm not even sure here what a device label is meant to be. I don't
> } suppose it's something mounted by LABEL=foo?
>
> I don't really know either. However, it's clear that in this case "usbfs"
> and "sunrpc" are virtual devices (since they appear in the first column
> of the mtab line) so perhaps "label" is just a misnomer?
>
> Either that, or _mount needs to interpret mtab positionally rather than
> by guessing that slashes are devices and everything else is a label.
>
> The "none" device (or label, or whatever) is filtered out.
>
> } My mount manpage mentions
> } partition labels, filesystem labels (and I know these are only
> } readable by root), and also 'those that are labeled "nodev"' appears.
>
> The only use of "nodev" in _mount is in _arguments arguments.
--
Mikael Magnusson
next prev parent reply other threads:[~2014-12-14 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 13:15 Silas Silva
2014-12-14 15:15 ` Mikael Magnusson
2014-12-14 16:53 ` Bart Schaefer
2014-12-14 17:13 ` Mikael Magnusson
2014-12-14 17:47 ` Bart Schaefer
2014-12-14 18:51 ` Mikael Magnusson [this message]
2014-12-14 16:31 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3QWZNzy6BeFuaYfzCPdF-vUCxfuJ=L1njGXF0Kg7NjCxA@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).