From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14058 invoked by alias); 25 Aug 2015 23:09:10 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: X-Seq: 20466 Received: (qmail 29524 invoked from network); 25 Aug 2015 23:09:09 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=szdrTsFAnm2PKGJ7rePgZFBvMM7DPRNdrviHLt8orgI=; b=WxUO9VwjujsR14y/fH8f0SNxRcU/T+px6Yt2rcRM34zUPlbHCne4WCNupCyHh7xMpS R8nIjr7yyDx17BX3TNVI6auWeKnGKN6zDhEB+v8qbmBxSHWah7poqxcB+OODwLDqBn8x S0G/+NOjnuS2ubqvbFr1GZ6rL4sbMdtKzx9IjJdqQz/KV5bamV7O1ca19EZIKI45qBRU RW9ixA4a6OpUKlt3/tsOEfeUc6qKOHhCq9zIhBwMrLepGbdQlvFOYhW+5sCoC/z8cbtM Ex5Q4hmyzg+WOmELBvt6+Vhd53/gKaSS3KcQMijH2/P46ubeFzzNq2U7WS4UDPy9OknT LrEQ== MIME-Version: 1.0 X-Received: by 10.141.28.80 with SMTP id f77mr74639048qhe.100.1440544147281; Tue, 25 Aug 2015 16:09:07 -0700 (PDT) In-Reply-To: <20150825222245.GA8276@lorien.comfychair.org> References: <20150825194807.194b3bed@ntlworld.com> <20150825222245.GA8276@lorien.comfychair.org> Date: Wed, 26 Aug 2015 01:09:07 +0200 Message-ID: Subject: Re: zsh 5.0.8.-test-3 From: Mikael Magnusson To: Danek Duvall , Peter Stephenson , Zsh Users Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Aug 26, 2015 at 12:22 AM, Danek Duvall wrot= e: > On Tue, Aug 25, 2015 at 07:48:07PM +0100, Peter Stephenson wrote: > >> I've uploaded 5.0.8-test-3 to >> >> http://www.zsh.org/pub/development/ >> >> The changes from 5.0.8.-test-2 are mostly minor; the most significant >> fixed testing using zpty on OpenBSD, thanks to Jun. >> >> If you have a not very common operating system, please try this out; >> otherwise, 5.1 should be fit to release. > > I'm getting the following failure on Solaris (12): > > *** /tmp/zsh.ztst.out.28050 Tue Aug 25 12:45:19 2015 > --- /tmp/zsh.ztst.tout.28050 Tue Aug 25 12:45:19 2015 > *************** > *** 1,4 **** > THURSDAY > ! JANUARY > 090 > 1 > --- 1,4 ---- > THURSDAY > ! %^_10B > 090 > 1 > Test ./V09datetime.ztst failed: output differs from expected as shown= above for: > if [[ $skip_extensions =3D 1 ]]; then > ZTST_skip=3D"strftime extensions not supported" > else > ( > strftime '%#A' 0 > strftime '%^_10B' 0 > strftime %03Ey 650000000 > strftime %-Oe 0 > ) > fi > Was testing: various extensions > ./V09datetime.ztst: test failed. > > Any ideas? Perhaps this particular set of strftime expandos aren't > supported on Solaris. So it seems. I don't have access to any obscure operating systems so I just guessed that if someone supported one extension, they'd support all of them. The one we test to see if we should skip the test is just zero-padding though which is pretty easy/obvious to implement. I guess we can check that one instead / as well. It looks like it supports both # and E too, so those wouldn't do the trick. diff --git i/Test/V09datetime.ztst w/Test/V09datetime.ztst index c935199..902fc6f 100644 --- i/Test/V09datetime.ztst +++ w/Test/V09datetime.ztst @@ -8,7 +8,7 @@ unset LC_ALL LC_TIME=3DC TZ=3DUTC+0 - [[ "$(strftime %04y 1)" =3D "0070" ]] || skip_extensions=3D1 + [[ "$(strftime %^_10B 0)" =3D " JANUARY" ]] || skip_extensions=3D1 [[ "$(LC_TIME=3Dja_JP.UTF-8 strftime %OS 1)" =3D =E4=B8=80 ]] || skip_ja= panese=3D1 %test Now the question is if someone supports that one, but not the others :). (If we try all of them and skip the test, the test approaches being sort of pointless, except we can notice it was skipped on a glibc system and realize something is wrong in our parsing.) --=20 Mikael Magnusson