zsh-users
 help / color / mirror / code / Atom feed
From: "Keerthan jai.c" <jckeerthan@gmail.com>
To: zsh-users@zsh.org
Subject: Re: Approximate file path completion for git?
Date: Sat, 11 Jan 2014 17:13:59 -0500	[thread overview]
Message-ID: <CAHyxEs0ZVrdfHChMbT-AnTqToYs9Mgxi7k2bSz_g34mU4T8aTw@mail.gmail.com> (raw)
In-Reply-To: <140111095818.ZM14468@torch.brasslantern.com>

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Backing out 31159 and unsetopt nomatch; works for me. However, unsetopt
nullglob breaks it again.


On Sat, Jan 11, 2014 at 12:58 PM, Bart Schaefer
<schaefer@brasslantern.com>wrote:

> On Jan 10, 11:37pm, Bart Schaefer wrote:
> }
> } -  files=(${(0)"$(_call_program files git ls-files -z --exclude-standard
> $opts -- ${pref:+$pref\\\*} 2>/dev/null)"})
> } +  files=(${(0)"$(setopt no_nomatch; _call_program files git ls-files -z
> --exclude-standard $opts -- ${pref:+$pref\*} 2>/dev/null)"})
>
> That needs nullglob turned off as well.  Here's a corrected patch:
>
>
> diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
> index 43a01d9..e9a5318 100644
> --- a/Completion/Unix/Command/_git
> +++ b/Completion/Unix/Command/_git
> @@ -5683,7 +5683,7 @@ __git_files () {
>    # TODO: --directory should probably be added to $opts when --others is
> given.
>
>    local pref=$gitcdup$gitprefix$PREFIX
> -  files=(${(0)"$(_call_program files git ls-files -z --exclude-standard
> $opts -- ${pref:+$pref\\\*} 2>/dev/null)"})
> +  files=(${(0)"$(unsetopt nullglob nomatch; _call_program files git
> ls-files -z --exclude-standard $opts -- ${pref:+$pref\*} 2>/dev/null)"})
>    __git_command_successful $pipestatus || return
>
>  #  _wanted $tag expl $description _files -g '{'${(j:,:)files}'}'
> $compadd_opts -
>



-- 
have a nice day
-jck

  reply	other threads:[~2014-01-11 22:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-11  4:50 Keerthan jai.c
2014-01-11  5:34 ` Bart Schaefer
2014-01-11  7:37   ` Bart Schaefer
2014-01-11 17:58     ` Bart Schaefer
2014-01-11 22:13       ` Keerthan jai.c [this message]
2014-01-11 23:41         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHyxEs0ZVrdfHChMbT-AnTqToYs9Mgxi7k2bSz_g34mU4T8aTw@mail.gmail.com \
    --to=jckeerthan@gmail.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).