5.0.2-test-2 is available

5.0.2-test-2 is available

[Peter Stephenson]

Another test for zsh 5.0.3 is available, 5.0.2-test-3, as you'll see if
you go to http://www.zsh.org/pub/development/ .  (The second compressed
version of the doc bundle was still to arrive when I looked but that
shouldn't worry you.)

I'm hoping this will be the last test version.

There are two reasonably significant changes since the previous test
version as noted below.  The first in particular could do with some
shaking down --- if you have a slightly out of the ordinary OS or
distribution it would be useful if you could try it out and report
problems.

There are also a few other bug fixes and function enhancements in the
last couple of weeks.


1. Helpfiles are now generated as part of the installation for use with
run-help (thanks to Martin Vaeth for kicking this off).  This needs a
certain amount of processing including Perl and some manual tools.  (If
anyone wants to volunteer to make this available as Yodl macros,
removing the additional dependencies, feel free and I'll send you a
charity Christmas card.)

If you've poked around the distribution, you'd have seen the tools for
these, but we've never tried to install the result by default ---
although the function run-help was installed and was therefore rather
less useful out of the box than it might have been.


2. Builtins that are marked to be loaded from modules (using "zmodload")
no longer cause an error if the module was already loaded.  This was
apparently causing a problem with the previous test version.


pws

Re: 5.0.2-test-2 is available

[d.henman]

Peter Stephenson wrote:
> Another test for zsh 5.0.3 is available, 5.0.2-test-3, as you'll see if
> you go to http://www.zsh.org/pub/development/ .  (The second compressed
> version of the doc bundle was still to arrive when I looked but that
> shouldn't worry you.)
> 
>...... --- if you have a slightly out of the ordinary OS or
> distribution it would be useful if you could try it out and report
> problems.
> ...........


I downloaded and successfully built the new test version on Cygwin, the Posix emulation layer.   The make check produced five test failures.

    FAIL V08zpty.ztst		 so the zpty module dies.

The first failed test is V08zpty.ztst, hangs indefinitely, which it normally does on
my Cygwin setup.  I think it has to do with Cygwin's emulating pipes or sockets or the 
like.

The other four tests which fail are, but they don't hang:
     FAIL Y01completion.ztst
     FAIL Y02compmatch.ztst
     FAIL Y03arguments.ztst


These failures commonly occur on Cygwin, but I still use zsh.  I guess I don't use the features relavent to the failed tests.   But, I would like to remove as many failures as possible.  If you can spot anything in the below that can be fixed in a manner that works on Cygwin would be good,

Regards

TEST/CHECK OUTPUT FOLLOWS:
#
# Below is output related to the four failure cases.
#
Renamed V08zpty.ztst to V08zpty.ztst.ignore
and reran  make check  which then fully ran.  Albeit with errors as shown below:

Test ./X02zlevi.ztst failed: non-zero status from preparation code:
  if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
    . $ZTST_srcdir/comptest
    comptestinit -v -z $ZTST_testdir/../Src/zsh
  else
    ZTST_unimplemented="the zsh/zpty module is not available"
  fi
./X02zlevi.ztst: test failed.
Test ./X02zlevi.ztst failed: bad status 1, expected 0 from:
  zletest $'one two\ebmt3|`tx``'
Was testing: setting mark and returning to original position
./X02zlevi.ztst: test failed.
 ----
./Y01completion.ztst: starting.
Test ./Y01completion.ztst failed: non-zero status from preparation code:
  if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
    . $ZTST_srcdir/comptest
    mkdir comp.tmp
    cd comp.tmp
    comptestinit -z $ZTST_testdir/../Src/zsh &&
    {
      mkdir dir1 &&
      mkdir dir2 &&
      touch file1 &&
      touch file2
    }
  else
    ZTST_unimplemented="the zsh/zpty module is not available"
  fi
./Y01completion.ztst: test failed.
Test ./Y01completion.ztst failed: bad status 1, expected 0 from:
  comptest $': \t\t\t\t\t\t\t'
Was testing: directories and files
./Y01completion.ztst: test failed.
 ----
./Y02compmatch.ztst: starting.
Test ./Y02compmatch.ztst failed: non-zero status from preparation code:
  if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
    . $ZTST_srcdir/comptest
    mkdir match.tmp
    cd match.tmp
    comptestinit -z $ZTST_testdir/../Src/zsh &&
    {
      list1=(IndianRed IndianRed2 IndianRed3 IndianRed4)
      test_code () {
        matcher=$1;
        list=$2;
        code="compdef _tst tst ; _tst () { echo -n '<COMPADD>';compadd -M '"
        code="$code$matcher"
        code="$code'  - ${(P)list} ; echo  -n '</COMPADD>'"
          code="$code; $extra_cmd"
          code="$code; echo -n '<INSERT_POSITIONS>'"
          code="$code; echo \$compstate[insert_positions]"
          code="$code; echo -n '</INSERT_POSITIONS>'"
          code="$code}"
        comptesteval "$code"
      }
    }
  else
    ZTST_unimplemented="the zsh/zpty module is not available"
  fi
./Y02compmatch.ztst: test failed.
Test ./Y02compmatch.ztst failed: bad status 1, expected 0 from:
 test_code z: list1
 comptest  $'tst \t'
Error output:
(eval):1: command not found: test_code
Was testing: Match Error for "z:"
./Y02compmatch.ztst: test failed.
 ----
./Y03arguments.ztst: starting.
Test ./Y03arguments.ztst failed: non-zero status from preparation code:
  if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
    . $ZTST_srcdir/comptest
    mkdir comp.tmp
    cd comp.tmp
    comptestinit -z $ZTST_testdir/../Src/zsh &&
    {
      comptesteval 'compdef _tst tst'
      tst_arguments () { comptesteval "_tst () { _arguments ${${(@qq)*}} }" }
    }
  else
    ZTST_unimplemented="the zsh/zpty module is not available"
  fi
./Y03arguments.ztst: test failed.
Test ./Y03arguments.ztst failed: bad status 1, expected 0 from:
 tst_arguments ':desc1:(arg1)'
 comptest $'tst \t\C-wa\t\C-war\t\C-warg\t\C-warg1\t\C-wr\t\C-wx\t \ty \t'
Error output:
(eval):1: command not found: tst_arguments
Was testing: one non-option argument
./Y03arguments.ztst: test failed.

**************************************
37 successful test scripts, 4 failures, 0 skipped
**************************************

End

Re: 5.0.2-test-2 is available

[Peter Stephenson]

On Mon, 02 Dec 2013 15:15:57 +0900
"d.henman" <dhenman@gmail.com> wrote:
> I downloaded and successfully built the new test version on Cygwin,
> the Posix emulation layer.   The make check produced five test
> failures. 
> 
>     FAIL V08zpty.ztst		 so the zpty module dies.
> 
> The first failed test is V08zpty.ztst, hangs indefinitely, which it
> normally does on my Cygwin setup.  I think it has to do with Cygwin's
> emulating pipes or sockets or the like.
> 
> The other four tests which fail are, but they don't hang:
>      FAIL Y01completion.ztst
>      FAIL Y02compmatch.ztst
>      FAIL Y03arguments.ztst

These could well be down to the same thing --- the completion tests use
zpty.

We could make the V08 tests a dependency for the completion tests,
although that's a higher level link than any we've had between the tests
before.

pws

Re: 5.0.2-test-2 is available

[Bart Schaefer]

On Dec 2,  3:15pm, d.henman wrote:
}
} These failures commonly occur on Cygwin, but I still use zsh. I guess
} I don't use the features relavent to the failed tests. But, I would
} like to remove as many failures as possible. If you can spot anything
} in the below that can be fixed in a manner that works on Cygwin would
} be good,

Well ...

} Test ./X02zlevi.ztst failed: non-zero status from preparation code:
} Test ./Y01completion.ztst failed: non-zero status from preparation code:
} Test ./Y01completion.ztst failed: bad status 1, expected 0 from:
} Test ./Y02compmatch.ztst failed: non-zero status from preparation code:

My best guess is that this means "comptestinit" is failing, because
later ...

} (eval):1: command not found: test_code
} (eval):1: command not found: tst_arguments

... and both of those are functions defined only when comptestinit has
succeeded.

So you could try to figure out why comptestinit fails, perhaps by adding
a "setopt xtrace" into Test/comptest, but really those tests should be
skipped if their environment can't be initialized.

-- 
Barton E. Schaefer

Re: 5.0.2-test-2 is available

[Axel Beckert]

Hi,

On Sun, Dec 01, 2013 at 07:46:53PM +0000, Peter Stephenson wrote:
> Another test for zsh 5.0.3 is available, 5.0.2-test-3, as you'll see if
> you go to http://www.zsh.org/pub/development/ .
[...]
> 1. Helpfiles are now generated as part of the installation for use with
> run-help (thanks to Martin Vaeth for kicking this off).  This needs a
> certain amount of processing including Perl and some manual tools.

Have to first figure out how to make the Debian package to work with
that change. Shouldn't be hard though.

5.0.2-test-1 btw. had one test-suite failure when building inside a
jenkins automatic build:
http://jenkins.grml.org/view/Debian/job/zsh-binaries/90/architecture=i386/console

As soon as I have 5.0.2-test-3 building, I'll check if that still
happens. Just thought, I should give a heads up as soon as possible
(since I've already waited to long to do so).

> 2. Builtins that are marked to be loaded from modules (using "zmodload")
> no longer cause an error if the module was already loaded.  This was
> apparently causing a problem with the previous test version.

Thanks for that fix. (Not yet verified, but I'm optimistic. :-)

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

Test suite failures on static build (was: 5.0.2-test-2 is available)

[Axel Beckert]

Hi,

On Sun, Dec 01, 2013 at 07:46:53PM +0000, Peter Stephenson wrote:
> Another test for zsh 5.0.3 is available, 5.0.2-test-3, as you'll see if
> you go to http://www.zsh.org/pub/development/ .

JFTR: Probably not that important, but I get the following test-suite
failures when doing a static build:

../../Test/C02cond.ztst: starting.
Test ../../Test/C02cond.ztst failed: bad status 1, expected 0 from:
  if (( EUID == 0 )); then
    print -u$ZTST_fd 'Warning: Not testing [[ ! -r file ]] (root reads anything)'
    [[ -r zerolength && -r unmodish ]]
  elif [[ $OSTYPE = cygwin ]]; then
    print -u$ZTST_fd 'Warning: Not testing [[ ! -r file ]]
   (all files created by user may be readable)'
   [[ -r zerolength ]]
  else
    [[ -r zerolength && ! -r unmodish ]]
  fi
Was testing: -r cond
../../Test/C02cond.ztst: test failed.
[…]
../../Test/E01options.ztst: starting.
This test hangs the shell when it fails...
*** /tmp/zsh.ztst.out.30124     Mon Dec  2 16:36:20 2013
--- /tmp/zsh.ztst.tout.30124    Mon Dec  2 16:36:20 2013
***************
*** 1,3 ****
  /home/abe/zsh/zsh/obj-static/Test/options.tmp /home/abe/zsh/zsh/obj-static/Test/options.tmp/tmpcd
! ~ /home/abe/zsh/zsh/obj-static/Test/options.tmp /home/abe/zsh/zsh/obj-static/Test/options.tmp/tmpcd
! /home/abe/zsh/zsh/obj-static/Test/options.tmp
--- 1,3 ----
  /home/abe/zsh/zsh/obj-static/Test/options.tmp /home/abe/zsh/zsh/obj-static/Test/options.tmp/tmpcd
! /home/abe/zsh/zsh/obj-static/Test/options.tmp /home/abe/zsh/zsh/obj-static/Test/options.tmp/tmpcd
! /home/abe/zsh/zsh/obj-static/Test/options.tmp/tmpcd
Test ../../Test/E01options.ztst failed: output differs from expected as shown above for:
  pushd $mydir/tmpcd
  pushd
  dirs
  setopt pushdtohome
  pushd
  dirs
  unsetopt pushdtohome
  popd
  pushd
  popd
  dirs
Error output:
(eval):pushd:5: no such file or directory: /home/abe/zsh/zsh/obj-static/testhome
(eval):pushd:9: no such file or directory: /home/abe/zsh/zsh/obj-static/testhome
(eval):popd:10: directory stack empty
Was testing: PUSHD_TO_HOME option
../../Test/E01options.ztst: test failed.
[…]
**************************************
33 successful test scripts, 2 failures, 7 skipped
**************************************

(Currently we do ignore the test suite results on the static build in
Debian.)

Test suite passes on normal builds.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.asciiribbon.org/              | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

Re: Test suite failures on static build (was: 5.0.2-test-2 is available)

[Peter Stephenson]

On Mon, 02 Dec 2013 16:51:19 +0100
Axel Beckert <abe@deuxchevaux.org> wrote:
> JFTR: Probably not that important, but I get the following test-suite
> failures when doing a static build:
> Error output:
> (eval):pushd:5: no such file or directory: /home/abe/zsh/zsh/obj-static/testhome
> (eval):pushd:9: no such file or directory: /home/abe/zsh/zsh/obj-static/testhome
> (eval):popd:10: directory stack empty
> Was testing: PUSHD_TO_HOME option

Could the exported value of HOME be funny?  It looks like we don't
sanitise it.

(Sorry, should have told people to reply to zsh-workers with detailed
reports.)

pws

Re: 5.0.2-test-2 is available

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Hi,


On Sun, Dec 1, 2013 at 9:46 PM, Peter Stephenson <
p.w.stephenson@ntlworld.com> wrote:

> Another test for zsh 5.0.3 is available, 5.0.2-test-3, as you'll see if
> you go to http://www.zsh.org/pub/development/ .  (The second compressed
> version of the doc bundle was still to arrive when I looked but that
> shouldn't worry you.)
>
> I'm hoping this will be the last test version.
>

Sorry for the late report. While building on openSUSE 13.1 I get:

 make[1]: Entering directory
`/home/abuild/rpmbuild/BUILD/zsh-5.0.2-test-3/Doc'
 texi2html --output . --ifinfo --split=chapter --node-files ./zsh.texi
 make[1]: Leaving directory
`/home/abuild/rpmbuild/BUILD/zsh-5.0.2-test-3/Doc'
 + install -d Help
 + pushd Help/
 ~/rpmbuild/BUILD/zsh-5.0.2-test-3/Help ~/rpmbuild/BUILD/zsh-5.0.2-test-3
 + troff -Tlatin1 -t -mandoc ../Doc/zshbuiltins.1
 + grotty -cbou
 + sed -e 's/±/{+|-}/'
 + ../Util/helpfiles
 Usage: helpfiles zshbuiltins.1 dest-dir [link-file]

Any ideas?

Re: 5.0.2-test-2 is available

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On Mon, Dec 9, 2013 at 11:51 AM, İsmail Dönmez <ismail@donmez.ws> wrote:

> Hi,
>
>
> On Sun, Dec 1, 2013 at 9:46 PM, Peter Stephenson <
> p.w.stephenson@ntlworld.com> wrote:
>
>> Another test for zsh 5.0.3 is available, 5.0.2-test-3, as you'll see if
>> you go to http://www.zsh.org/pub/development/ .  (The second compressed
>> version of the doc bundle was still to arrive when I looked but that
>> shouldn't worry you.)
>>
>> I'm hoping this will be the last test version.
>>
>
> Sorry for the late report. While building on openSUSE 13.1 I get:
>
>  make[1]: Entering directory
> `/home/abuild/rpmbuild/BUILD/zsh-5.0.2-test-3/Doc'
>  texi2html --output . --ifinfo --split=chapter --node-files ./zsh.texi
>  make[1]: Leaving directory
> `/home/abuild/rpmbuild/BUILD/zsh-5.0.2-test-3/Doc'
>  + install -d Help
>  + pushd Help/
>  ~/rpmbuild/BUILD/zsh-5.0.2-test-3/Help ~/rpmbuild/BUILD/zsh-5.0.2-test-3
>  + troff -Tlatin1 -t -mandoc ../Doc/zshbuiltins.1
>  + grotty -cbou
>  + sed -e 's/±/{+|-}/'
>  + ../Util/helpfiles
>  Usage: helpfiles zshbuiltins.1 dest-dir [link-file]
>
> Any ideas?
>

Looks like the following rpm spec file fragment triggers this:

 # make help text files
 install -d Help
 pushd Help/
 troff -Tlatin1 -t -mandoc ../Doc/zshbuiltins.1 | \
      grotty -cbou | \
      sed -e 's/±/{+|-}/' | \
      ../Util/helpfiles
 popd