From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Christian Heinrich <christian@gladbachcity.de>
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: Feature request (@M):# with context matches
Date: Sat, 30 Jan 2016 16:34:21 +0100 [thread overview]
Message-ID: <CAKc7PVAmtDh7dJSg3_qfz+7NEB4_X+mwiJVnGKFOoYh1JLG_VQ@mail.gmail.com> (raw)
In-Reply-To: <1454164684.1526.25.camel@gladbachcity.de>
On 30 January 2016 at 15:38, Christian Heinrich
<christian@gladbachcity.de> wrote:
> Hi Sebastian,
>
> I'm not sure what you want to do, but I my guts tells me that you want
> to re-invent the wheel as you stated that you want to replace several
> tools with ZSH. If you can achieve your goal by calling a GNU tool, you
> should do that. These are mature tools and there is nothing wrong about
> using them. (And it's certainly a benefit that you don't have to
> maintain them.)
>
> Calling "grep" is also more understandable by everyone than the pattern
> you gave in your first email.
I'll try to contradict the "more understandable" with an example –
antigen, a probably very well written BSG code. Take this function for
example:
https://github.com/zsh-users/antigen/blob/master/antigen.zsh#L100-L112
antigen-bundles () {
# Bulk add many bundles at one go. Empty lines and lines starting with a `#`
# are ignored. Everything else is given to `antigen-bundle` as is, no
# quoting rules applied.
local line
grep '^[[:space:]]*[^[:space:]#]' | while read line; do
# Using `eval` so that we can use the shell-style quoting in each line
# piped to `antigen-bundles`.
eval "antigen-bundle $line"
done
}
For me it's hard to understand this function. Grep, forks, pipes,
evals. My point is that this is what "$( )" leads to in general.
That's what ABSG advises to do, and such code is spread everywhere,
across companies, open source projects. Other example:
https://github.com/zsh-users/antigen/blob/master/antigen.zsh#L347-L355
# Find directores in ADOTDIR/repos, that are not in the bundles record.
local unused_clones="$(comm -13 \
<(-antigen-echo-record |
awk '$4 == "true" {print $1}' |
while read line; do
-antigen-get-clone-dir "$line"
done |
sort -u) \
<(\ls -d "$ADOTDIR/repos/"* | sort -u))"
This is one candidate to most outstanding BSG snippet in the project.
On the other hand, such programming is maybe something distinct from
typical imperative programming. With my "GNU -> zsh" document, I would
maybe advocate how to do normal programming in Zsh. But I believe I
wouldn't, Zsh has it's own unique traits, own ways of compressing much
into little of code, without use of Awk.
Best regards,
Sebastian Gniazdowski
next prev parent reply other threads:[~2016-01-30 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 10:15 Sebastian Gniazdowski
2016-01-30 12:13 ` Sebastian Gniazdowski
2016-01-30 14:38 ` Christian Heinrich
2016-01-30 15:34 ` Sebastian Gniazdowski [this message]
2016-01-30 16:54 ` Bart Schaefer
2016-01-30 20:42 ` Bart Schaefer
[not found] ` <160130085456.ZM9730__49922.0612728552$1454172936$gmane$org@torch.brasslantern.com>
2016-02-07 0:22 ` min() max() math functions (was: Re: Feature request (@M):# with context matches) Daniel Shahaf
2016-02-07 1:00 ` Bart Schaefer
[not found] ` <160206170040.ZM1927__13399.3204137825$1454806909$gmane$org@torch.brasslantern.com>
2016-02-09 3:23 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKc7PVAmtDh7dJSg3_qfz+7NEB4_X+mwiJVnGKFOoYh1JLG_VQ@mail.gmail.com \
--to=sgniazdowski@gmail.com \
--cc=christian@gladbachcity.de \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).