From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: "zsh-users@zsh.org" <zsh-users@zsh.org>
Subject: Re: Feature request: a new warning option
Date: Wed, 9 Oct 2019 15:41:41 +0200 [thread overview]
Message-ID: <CAKc7PVBQnt_ZE3X=8gz5R_VURwaTL3mDL=X-7H__yYqAjvXoWA@mail.gmail.com> (raw)
In-Reply-To: <1570627441.5764.11.camel@samsung.com>
On Wed, 9 Oct 2019 at 15:25, Peter Stephenson <p.stephenson@samsung.com> wrote:
>
> Hmm... that's fair enough, but if you're happy to trade off against
> readability I think you have to take possible difficulties with the
> syntax on the chin...
I thought that:
[[ -z $ver ]] && ver="unknown (no .git/refs/heads/master)" || ver=${ver[1,7]}
is more or equally readable to:
if [[ -z $ver ]]; then
ver="unknown (no .git/refs/heads/master)"
else
ver=${ver[1,7]}
fi
especially if I would format it like I would today:
[[ -z $ver ]] && \
ver="unknown (no .git/refs/heads/master)" || \
ver=${ver[1,7]}
but I'm seeing your point. This is like commenting or not the code – I
was for a long long time pro-commenting, to just drop it recently,
actually finding pleasure in writing a condensed, I could agree –
(less /un)readable code.
--
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org
next prev parent reply other threads:[~2019-10-09 13:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 4:02 Sebastian Gniazdowski
2019-10-09 8:45 ` Roman Perepelitsa
2019-10-09 8:49 ` Peter Stephenson
2019-10-09 11:56 ` Sebastian Gniazdowski
2019-10-09 12:08 ` Roman Perepelitsa
2019-10-09 13:17 ` Sebastian Gniazdowski
2019-10-09 13:24 ` Peter Stephenson
2019-10-09 13:41 ` Sebastian Gniazdowski [this message]
2019-10-09 14:07 ` Ray Andrews
2019-10-09 15:19 ` Peter Stephenson
[not found] ` <CAKc7PVBQnt_ZE3X=8gz5R_VURwaTL3mDL=X-7H__yYqAjvXoWA__41912.055101578$1570628583$gmane$org@mail.gmail.com>
2019-10-09 14:04 ` Stephane Chazelas
2019-10-09 13:40 ` Roman Perepelitsa
2019-10-09 17:36 ` Daniel Shahaf
2019-10-09 18:15 ` Bart Schaefer
2019-10-10 3:29 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKc7PVBQnt_ZE3X=8gz5R_VURwaTL3mDL=X-7H__yYqAjvXoWA@mail.gmail.com' \
--to=sgniazdowski@gmail.com \
--cc=p.stephenson@samsung.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).