From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: Why the widget bound to menuselect isn't called?
Date: Sun, 14 Jul 2019 23:56:01 +0200 [thread overview]
Message-ID: <CAKc7PVBxCzFRab6MvcyGT1QeRpK0XVEF4e0zUfXJmZAA24AbTQ@mail.gmail.com> (raw)
In-Reply-To: <53445-1563100701.603642@DtMP.e8mM.jHzi>
On Sun, 14 Jul 2019 at 12:38, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> The automatic mapping is harder
> because an approach needs to be worked out and designed.
> ...
> I'm not sure I follow what you're saying. It may have been better if
> there had been fine-grained widgets to begin with but that alone is not
> sufficient (either now or at the time of the module's inception).
I was making a point that the automatic mapping solely for the
menuselect case is actually available – despite being probably not at
the level of quality and design that we would expect from it – because
the complist module does automatically get the calls if they're done
on the menuselect keymap. So to solve the particular issue with
non-overloadable menuselect widgets what has to be done is to provide
the rest of the Zle widgets – to give them meaning in the menuselect
keymap, so that there's no risk that user's overloading widget will
call something's unimplemented – the Zsh script code isn't a threat
here, only the dot- i.e. original zle .widgets are.
> > It seems that it is about forwarding the keymap-specific mechanism to
> > the Zshell code in an consistent way with the C code. The question is
> > is this necessary?
>
> Consistency with Functions/Zle/keymap+widget isn't necessary.
> Not breaking backwards compatibility that allows menu selection key
> bindings to reflect users' normal key bindings is necessary. I was
> trying to outline some vague ideas on how this might be approached.
I wonder if the enabling of overloading of the menuselect keymap
doesn't break the backwards compatibility. The "always leave
menu-selection" behavior, for example, will be changed by it. An
configuration option, rather preferably zstyle, could be used to guard
the compatible behavior (BTW. are zstyles used to influence Zshell at
the C level currently?).
--
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org
prev parent reply other threads:[~2019-07-14 21:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 20:55 Sebastian Gniazdowski
2019-07-12 18:44 ` Sebastian Gniazdowski
2019-07-12 19:36 ` Bart Schaefer
2019-07-13 1:23 ` Sebastian Gniazdowski
2019-07-13 2:29 ` Ben Klein
2019-07-13 8:59 ` Oliver Kiddle
2019-07-13 12:19 ` Sebastian Gniazdowski
2019-07-13 12:23 ` Sebastian Gniazdowski
2019-07-13 16:39 ` Bart Schaefer
2019-07-13 16:42 ` Bart Schaefer
2019-07-14 10:38 ` Oliver Kiddle
2019-07-14 21:56 ` Sebastian Gniazdowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKc7PVBxCzFRab6MvcyGT1QeRpK0XVEF4e0zUfXJmZAA24AbTQ@mail.gmail.com \
--to=sgniazdowski@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).